This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })();
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts - #407

Merged
jan-auer merged 4 commits into
masterfrom
feat/trace-context
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts#407
jan-auer merged 4 commits into
masterfrom
feat/trace-context

Conversation

@jan-auer

@jan-auerjan-auer commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@jan-auer
jan-auer merged commit 86fe153 into masterAug 23, 2021
@jan-auer
jan-auer deleted the feat/trace-context branch August 23, 2021 12:47
@bruno-garciabruno-garcia mentioned this pull request Aug 23, 2021
Closed
rhcarvalho
rhcarvalho reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/components/sidebar.tsx
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

Comment threadsrc/docs/sdk/trace-context.mdx
@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"

@rhcarvalhorhcarvalhoAug 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

@jan-auerjan-auerAug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

@RaduWRaduWAug 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
2 more reviewers
@rhcarvalhorhcarvalhorhcarvalho left review comments
@RaduWRaduWRaduW left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@rhcarvalho@RaduW