Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(transactions): Add transaction_info.source [INGEST-1427] - #624

Merged
jjbayer merged 7 commits into
masterfrom
feat/transaction-source
Jul 4, 2022
Merged

feat(transactions): Add transaction_info.source [INGEST-1427]#624
jjbayer merged 7 commits into
masterfrom
feat/transaction-source

Conversation

@jjbayer

@jjbayerjjbayer commented Jun 30, 2022

Copy link
Copy Markdown
Member

Add a source label to every transaction that indicates how the transaction name was generated, as decided in https://www.notion.so/sentry/Annotating-Transaction-Names-a08a05ff97b348b0903de03a17baa731.

Rendered version is here and will be included on the "Transaction Type" page.

@vercel

vercelBot commented Jun 30, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
develop✅ Ready (Inspect)Visit PreviewJul 1, 2022 at 0:18AM (UTC)

Comment threadsrc/docs/sdk/event-payloads/properties/transaction_info.mdx Outdated
@jjbayer
jjbayer marked this pull request as ready for review June 30, 2022 07:23

@jan-auerjan-auer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update other places, such as:

Comment threadsrc/docs/sdk/event-payloads/properties/transaction_info.mdx Outdated
Comment threadsrc/docs/sdk/event-payloads/properties/transaction_info.mdx Outdated
Comment threadsrc/docs/sdk/event-payloads/properties/transaction_info.mdx Outdated
@jjbayer

Copy link
Copy Markdown
MemberAuthor

Should we also update other places, such as:

@jan-auer I added a reference in "Guidelines for PM". Not sure about the Unified API, do you mean as a second parameter to set_transaction()? Would this not automatically become public API? I assume we want to prevent the user from setting the source themselves.

@jan-auer

Copy link
Copy Markdown
Member

Redirecting this question to @AbhiPrasad. Would you expect "internal" APIs into the Unified API docs, for example the optional argument for setting a transaction with source?

@untitakeruntitaker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to the public docs, after all SDKs need to know how to send this

Comment threadsrc/docs/sdk/event-payloads/properties/transaction_info.mdx Outdated
@untitakeruntitaker changed the title feat(transactions): Add transaction_info.sourcefeat(transactions): Add transaction_info.source [INGEST-1427]Jul 1, 2022
@jjbayer
jjbayer merged commit 151ab50 into masterJul 4, 2022
@jjbayer
jjbayer deleted the feat/transaction-source branch July 4, 2022 09:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jjbayer@jan-auer@untitaker@AbhiPrasad