Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Remove data from DSC specification that is potentially PII - #631

Merged
lforst merged 4 commits into
masterfrom
lforst-remove-pii-from-dsc-spec
Jul 6, 2022
Merged

Remove data from DSC specification that is potentially PII#631
lforst merged 4 commits into
masterfrom
lforst-remove-pii-from-dsc-spec

Conversation

@lforst

@lforstlforst commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

As discussed we (for now) want to remove potentially PII violating data from the Dynamic Sampling Context spec. This PR removes it.

@vercel

vercelBot commented Jul 5, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
develop✅ Ready (Inspect)Visit PreviewJul 6, 2022 at 11:31AM (UTC)

@lforstlforst changed the title Remove data from DSC which is potentially PIIRemove data from DSC spec which is potentially PIIJul 5, 2022
@lforst

lforst commented Jul 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Sorry for review spam. I want everybody to be aware of this.

marandaneto
marandaneto reviewed Jul 5, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/dynamic-sampling-context.mdx Outdated
@Lms24Lms24 mentioned this pull request Jul 5, 2022
Merged
Lms24
Lms24 approved these changes Jul 5, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/dynamic-sampling-context.mdx Outdated
philipphofmann
philipphofmann reviewed Jul 6, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/dynamic-sampling-context.mdx Outdated
lforstand others added 2 commits July 6, 2022 13:27
@lforst@Lms24
h4 to h3
2c65753
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Luca Forstner
Remove commented out code
b714ed2
@lforst
lforst enabled auto-merge (squash) July 6, 2022 11:29
@lforst
lforst disabled auto-merge July 6, 2022 11:29
@lforstlforst changed the title Remove data from DSC spec which is potentially PIIRemove data from DSC specification that is potentially PIIJul 6, 2022
@lforst
lforst enabled auto-merge (squash) July 6, 2022 11:29
@lforst
lforst merged commit 88049ba into masterJul 6, 2022
@lforst
lforst deleted the lforst-remove-pii-from-dsc-spec branch July 6, 2022 11:32
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@untitakeruntitakerAwaiting requested review from untitaker
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@adinaueradinauerAwaiting requested review from adinauer
@jan-auerjan-auerAwaiting requested review from jan-auer
@lobsterkatielobsterkatieAwaiting requested review from lobsterkatie
@mitsuhikomitsuhikoAwaiting requested review from mitsuhiko
4 more reviewers
@philipphofmannphilipphofmannphilipphofmann left review comments
@marandanetomarandanetomarandaneto left review comments
@jjbayerjjbayerjjbayer approved these changes
@Lms24Lms24Lms24 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lforst@jjbayer@philipphofmann@marandaneto@Lms24