Uh oh!
There was an error while loading. Please reload this page.
Add transaction back to DSC specification - #635
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
left a comment
There was a problem hiding this comment.
I think this is a good general description for "good quality" transaction names.
Wondering if the dependence for transaction being added to the DSC on the transaction source should be a hard requirement instead of a suggestion. But as long as Relay doesn't make sampling decisions based on the source (which IIRC and according to the spec) I think we can leave this open to SDK implementors.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Good input! The reason I wrote it like this and also didn't make it a hard-requirement to have the transaction on the DSC based on transaction source, is because not all SDKs have the problem of "low quality transaction names" like the JS SDK with URLs and additionally not all SDKs will have to provide a transaction source until relay makes it required. |
Lms24
commented
Jul 8, 2022
Yeah, makes sense to leave it as is for now |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Resolves#634