Add app_memory to app context

[timfish]

Currently the device context has properties for the device memory usage but it can be useful to know how much memory an app was using when an event or transaction was captured.

Open to better naming than memory_used 🤔

Related issues:
getsentry/sentry-cocoa#999

[vercel]

@timfish is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

[bruno-garcia]

@jan-auer@mattjohnsonpint@marandaneto@AbhiPrasad thoughts?

[timfish]

Might also be worth including storage_used to help with this:
https://github.com/getsentry/team-mobile/issues/8

[bruno-garcia]

Dotnet sdk has "Memory Info", i believe the
units are not well defined. So the ui doesn't present KB/MB etc, just shows as-is

[AbhiPrasad]

I'm +1 on adding this, and I think memory_used effectively articulates what it's doing.

If we are worried about units not being well defined, we could also just include the unit as part of the value.
For example, "memory_used": "30 kB". Thoughts on that? We are probably not going to index this - so I don't think we need to worry about high cardinality concerns.

[timfish]

Everything in contexts is in bytes apart from gpu.memory_sizewhich is in Megabytes.

[marandaneto]

Android SDK already reports contexts.device.memory_size, contexts.device.free_memory and contexts.device. usable_memory, all in bytes.
IIRC, if we add fields to the spec, we need validation on relay first.
Since the contexts accept any unknown value, you could technically just send it unless you want to standardize across SDKs.
Ideally, we'd also customize the UI when showing the field from the raw key such as free_memory to a more human-readable version such as Free Memory or something similar, that would be on https://github.com/getsentry/sentry/blob/53fe8ba3447b010e75932175a0ebf9e9edad3b6a/static/app/components/events/contexts/device/getDeviceKnownDataDetails.tsx#L87

[timfish]

There are a large number of properties documented in contexts.device that are not specifically handled in Relay or Sentry right now such as boot_time, processor_count, processor_frequency and all the supports_*.

[AbhiPrasad]

Yeah only a certain few fields are indexed. If you want to see the full list -> https://github.com/getsentry/sentry/blob/master/src/sentry/snuba/events.py

https://github.com/getsentry/sentry/blob/0ce68802e966fe49a595ee1697804929c2a55f50/src/sentry/snuba/events.py#L240-L316

[AbhiPrasad]

We can open up a GH issue on the Sentry repo to add memory_used to the UI after we merge the spec in!

[brustolin]

I want to suggest to keep pattern and call it "app_memory"

[brustolin]

@AbhiPrasad, @bruno-garcia, What else do we need to merge this?

[AbhiPrasad]

This is good to me! As a follow up, we'll need to add to https://github.com/getsentry/relay/blob/b0df53e26ce780639e9f693331b23991f28c2d3c/relay-general/src/protocol/contexts.rs#L221

[AbhiPrasad]

I'm going to go ahead and merge this! I'll take care of updating relay.