Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Add UI event transactions - #766

Merged
philipphofmann merged 20 commits into
masterfrom
feat/ui-event-transactions
Nov 21, 2022
Merged

Add UI event transactions#766
philipphofmann merged 20 commits into
masterfrom
feat/ui-event-transactions

Conversation

@philipphofmann

@philipphofmannphilipphofmann commented Nov 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Add specification for UI event transactions with Gherkin syntax.

FixesGH-647

@philipphofmann
Add docs for UI event transactions
ff51a11
Add specification for UI event transactions with Gherkin syntax.
@vercel

vercelBot commented Nov 17, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
develop✅ Ready (Inspect)Visit PreviewNov 21, 2022 at 7:57AM (UTC)

marandaneto
marandaneto reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
marandaneto
marandaneto reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
marandaneto
marandaneto reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
marandaneto
marandaneto reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
marandaneto
marandaneto reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
@philipphofmannphilipphofmann changed the title Add docs for UI event transactionsAdd UI event transactionsNov 17, 2022
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx
romtsn
romtsn reviewed Nov 17, 2022
View reviewed changes

@romtsnromtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a boolean option in SentryOptions (enableUserInteractionTracing), should we mentioned it here?

@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
ab0582c
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmannphilipphofmann mentioned this pull request Nov 18, 2022
Closed
marandaneto
marandaneto approved these changes Nov 18, 2022
View reviewed changes

@marandanetomarandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @philipphofmann and once more, thank you for doing this.

romtsn
romtsn reviewed Nov 18, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn reviewed Nov 18, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
5ebf5eb
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
philipphofmannand others added 4 commits November 18, 2022 14:45
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
6e4ac9d
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
b48af6f
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
2a30bec
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmann
minor fix
d635fa5
@philipphofmannphilipphofmann mentioned this pull request Nov 18, 2022
Closed
@philipphofmann
philipphofmann marked this pull request as ready for review November 18, 2022 13:59
romtsn
romtsn reviewed Nov 18, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx
romtsn
romtsn reviewed Nov 18, 2022
View reviewed changes
Comment threadsrc/docs/sdk/performance/ui-event-transactions.mdx Outdated
romtsn
romtsn approved these changes Nov 18, 2022
View reviewed changes

@romtsnromtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor fixes + still missing enableUserInteractionTracing option. Otherwise, LGTM 👍 thanks for doing that

philipphofmannand others added 2 commits November 21, 2022 08:47
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
e81ad0d
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmann@romtsn
Update src/docs/sdk/performance/ui-event-transactions.mdx
5a3d7e1
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@philipphofmann
philipphofmann enabled auto-merge (squash) November 21, 2022 07:56
@philipphofmann
philipphofmann merged commit 6362323 into masterNov 21, 2022
@philipphofmann
philipphofmann deleted the feat/ui-event-transactions branch November 21, 2022 07:59
@marandanetomarandaneto mentioned this pull request Nov 21, 2022
Closed
@AbhiPrasadAbhiPrasad mentioned this pull request Nov 21, 2022
Merged
@philipphofmannphilipphofmann mentioned this pull request Nov 21, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@romtsnromtsnromtsn approved these changes
@marandanetomarandanetomarandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document UI Event Transaction

3 participants

@philipphofmann@romtsn@marandaneto