Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Specification: Better scrubbing of sensitive data - #773

Merged
antonpirker merged 9 commits into
masterfrom
antonpirker/772-better-data-scrubbing
Jan 11, 2023
Merged

Specification: Better scrubbing of sensitive data#773
antonpirker merged 9 commits into
masterfrom
antonpirker/772-better-data-scrubbing

Conversation

@antonpirker

@antonpirkerantonpirker commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

In RFC-0038 we decided to implement better data scrubbing of sensitive data.

This is now the specification that all SDKs and Relay can implement to have better data scrubbing.

@vercel

vercelBot commented Nov 24, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
develop✅ Ready (Inspect)Visit PreviewJan 11, 2023 at 1:30PM (UTC)

@cleptriccleptric self-assigned this Nov 24, 2022
@cleptriccleptric removed their assignment Nov 28, 2022
This was referenced Dec 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@antonpirkerantonpirker mentioned this pull request Dec 1, 2022
Closed
@smeubanksmeubank mentioned this pull request Dec 2, 2022
Closed
cleptric
cleptric reviewed Dec 5, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
cleptric
cleptric reviewed Dec 5, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
@mattjohnsonpintmattjohnsonpint mentioned this pull request Dec 6, 2022
Closed
gggritso
gggritso reviewed Dec 6, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx
gggritso
gggritso reviewed Dec 6, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
gggritso
gggritso reviewed Dec 6, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx
@antonpirker@cleptric
Update src/docs/sdk/data-handling.mdx
39c4b1b
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
@antonpirker
antonpirker marked this pull request as ready for review December 14, 2022 13:15
marandaneto
marandaneto reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx
cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx
cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx
cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
- The username logged in the device is not included. This is often a person's name.
- The machine name is not included, for example `Bruno's laptop`
- SDKs don't set `{{auto}}` as `user.ip`. This instructs the server to keep the connection's IP address.\*
- Specifically about IP address, it's important to note that it's standard to log IP address of incoming connecting in services on the Internet.

@cleptriccleptricDec 14, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has some GDPR impact. While I agree that having an IP address attached to an event can be useful, we might reword this a bit.

cleptric
cleptric reviewed Dec 14, 2022
View reviewed changes
Comment threadsrc/docs/sdk/data-handling.mdx Outdated
@antonpirker@marandaneto
Update src/docs/sdk/data-handling.mdx
d92805f
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@antonpirker
antonpirker enabled auto-merge (squash) January 11, 2023 13:29
@antonpirker
antonpirker merged commit 8fd68b2 into masterJan 11, 2023
@antonpirker
antonpirker deleted the antonpirker/772-better-data-scrubbing branch January 11, 2023 13:30
@aldenquimbyaldenquimby mentioned this pull request Feb 16, 2023
Closed
2 tasks
@kahestkahest mentioned this pull request Apr 21, 2023
Closed
@jamescrosswelljamescrosswell mentioned this pull request May 15, 2023
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers
@gggritsogggritsogggritso left review comments
@jjbayerjjbayerjjbayer left review comments
@marandanetomarandanetomarandaneto left review comments
@cleptriccleptriccleptric left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@antonpirker@gggritso@jjbayer@marandaneto@cleptric@stephanie-anderson