Uh oh!
There was an error while loading. Please reload this page.
fix(validate-pr): Address review feedback - #154
Merged
Conversation
- Paginate comment listing in enforce-draft.js to handle PRs with 30+ comments - Add null check on comment user property for deleted/suspended accounts - Clarify in README that maintainers are only exempt from issue validation, not draft enforcement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #153. Addresses review feedback from sentry[bot] and cursor[bot]:
listCommentsonly returns thefirst 30 results by default. PRs with many comments could get duplicate bot
comments on reopen. Now uses
github.paginate()consistent withvalidate-pr.js.c.userbeing null fordeleted/suspended GitHub accounts (
c.user?.typeinstead ofc.user.type).validation, not draft enforcement. Draft enforcement is intentionally applied
to everyone.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com