Skip to content

feat(validate-pr): Skip checks for users with write access - #162

Merged
stephanie-anderson merged 2 commits into
mainfrom
feat/validate-pr-skip-write-access
Apr 1, 2026
Merged

feat(validate-pr): Skip checks for users with write access#162
stephanie-anderson merged 2 commits into
mainfrom
feat/validate-pr-skip-write-access

Conversation

@stephanie-anderson

@stephanie-andersonstephanie-anderson commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Users with write repository access (admin, maintain, or write role) now bypass PR validation checks
  • Maintainer-only checks (reopening closed PRs, counting as maintainer in issue discussions) remain restricted to admin/maintain roles
  • Refactored permission helpers into getRole (cached API call), hasWriteAccess (admin/maintain/write), and isMaintainer (admin/maintain)

Users with write repository access (admin, maintain, or write role) now
bypass PR validation. Maintainer-only checks (reopening closed PRs,
counting as maintainer in issue discussions) remain restricted to
admin/maintain roles.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actionsBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️Could not load custom Dangerfile: .github/test-dangerfile-curl.js Error: ENOENT: no such file or directory, lstat '/github/workspace/.github/test-dangerfile-curl.js'
Messages
📖Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3ea332a

Comment threadvalidate-pr/scripts/validate-pr.js
The GitHub API returns "push" (not "write") for the role_name field.
Keep "write" in the list for forward compatibility.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadvalidate-pr/scripts/validate-pr.js
@stephanie-anderson
stephanie-anderson merged commit 71588dd into mainApr 1, 2026
22 checks passed
This was referenced Apr 1, 2026
stephanie-anderson added a commit to getsentry/sentry-rust that referenced this pull request Apr 1, 2026
Update validate-pr action to getsentry/github-workflows@71588dd.
Changes included:
- Skip all checks when a maintainer reopens a PR
(getsentry/github-workflows#161)
- Skip checks for users with write access
(getsentry/github-workflows#162)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanie-anderson added a commit to getsentry/sentry-python that referenced this pull request Apr 1, 2026
Update validate-pr action to getsentry/github-workflows@71588dd.
Changes included:
- Skip all checks when a maintainer reopens a PR
(getsentry/github-workflows#161)
- Skip checks for users with write access
(getsentry/github-workflows#162)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanie-anderson added a commit to getsentry/sentry-javascript that referenced this pull request Apr 1, 2026
Update validate-pr action to getsentry/github-workflows@71588dd.
Changes included:
- Skip all checks when a maintainer reopens a PR
(getsentry/github-workflows#161)
- Skip checks for users with write access
(getsentry/github-workflows#162)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vaind
vaind deleted the feat/validate-pr-skip-write-access branch May 11, 2026 09:40
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Update validate-pr action to getsentry/github-workflows@71588dd.
Changes included:
- Skip all checks when a maintainer reopens a PR
(getsentry/github-workflows#161)
- Skip checks for users with write access
(getsentry/github-workflows#162)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@stephanie-anderson