Uh oh!
There was an error while loading. Please reload this page.
feat(validate-pr): Make advisory; drop close + labels - #163
Merged
Conversation
- Drop close-on-failure and label application; post a single warm advisory comment instead. - Add small-PR bypass: skip validation when a PR has fewer than 100 lines changed, excluding common lock files (Cargo.lock, yarn.lock, package-lock.json, etc.). - Remove maintainer-reopen-skip (no longer needed without close logic). - Add idempotence guard via apps.getAuthenticated() to avoid duplicate comments on workflow re-runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Wrap pulls.listFiles in try/catch with fail-through to validation, so a transient GitHub API error does not abort the advisory action. - Tighten the bot-login warning to explain the consequence (the duplicate-comment guard is disabled for that run). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The advisory action no longer closes PRs, so the was-closed output is meaningless. Dropping it as part of the v4 behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Document advisory behavior, the small-PR + lock-file bypass, and the migration path from v3 (close + labels removed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Also corrects the original v3-era entry to drop the "enforcing draft status" language — that part of the feature was removed in #159 and never shipped in a tagged release. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Uh oh!
There was an error while loading. Please reload this page.
…otence The previous code called github.rest.apps.getAuthenticated() to resolve the bot login, but that endpoint requires JWT auth — our github client is authenticated with an installation access token, so the call always failed. The catch handler then left botLogin null, the idempotence check was skipped, and re-runs of the workflow could produce duplicate comments. Pass the app slug via env var from create-github-app-token's app-slug output (added in v2 of that action) and construct the bot login as "<slug>[bot]" directly. No API call needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Consumers in getsentry/* pin this action by commit SHA, not by @v* tags or major-version moving tags. Update the README example and the "updating earlier revisions" section to reflect that. Drop the "Breaking changes" framing in the changelog — the action has not shipped in a tagged release, so calling it a breaking change overstates the impact. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the
validate-praction from enforcing (closes PRs + applies labels) to advisory (single warm comment, no labels, never closes), and add a small-PR bypass that ignores common lock-file churn.Cargo.lock,yarn.lock,package-lock.json,Pipfile.lock,go.sum, etc.) are skipped entirely.was-closedoutput — no longer meaningful.[opened]only (dropreopened).Consumers pin this action by commit SHA. After this lands, each consumer needs to bump the pinned SHA, change the trigger to
[opened], and drop any reads of thewas-closedoutput. Handled separately as a fan-out across the SDK repos.