Skip to content

chore(deps): update Danger JS to v14.0.6#172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base:main
Choose a base branch
from
Open

chore(deps): update Danger JS to v14.0.6 #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,12 @@

- Danger - Harden `extra-install-packages` handling: pass the package list into the container via env var instead of host-shell string interpolation (defense in depth) ([#169](https://github.com/getsentry/github-workflows/pull/169))

### Dependencies

- Bump Danger JS from v13.0.5 to v14.0.6 ([#172](https://github.com/getsentry/github-workflows/pull/172))
- [changelog](https://github.com/danger/danger-js/blob/main/CHANGELOG.md#1406)
- [diff](https://github.com/danger/danger-js/compare/13.0.5...14.0.6)

## 3.4.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion danger/danger.properties
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
version=13.0.5
version=14.0.6

@sentrysentryBotAug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The action may fail if the Docker image for the specified version in danger.properties doesn't exist in the container registry at runtime, causing CI failures.
Severity: HIGH

Suggested Fix

The dependency updater script should be modified to verify that the Docker image for a new version exists in the container registry before creating a pull request to update the version. Alternatively, the action could implement a fallback or retry mechanism for Docker image pulls.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: danger/danger.properties#L1
Potential issue: The version specified in `danger/danger.properties` is used to
construct a Docker image tag, `ghcr.io/danger/danger-js:${DANGER_VERSION}`. The
automated process that updates this version number only verifies the existence of a
corresponding Git tag, not the availability of the Docker image in the GitHub Container
Registry. If this action runs after the version is updated but before the corresponding
Docker image is published, the `docker run` command will fail with an image pull error,
causing all CI workflows that depend on this action to fail.

repo=https://github.com/danger/danger-js