Skip to content

Add insight for 16kb page ready - #517

Open
chromy wants to merge 1 commit into
mainfrom
chromy/2025-12-10-16kb-ready
Open

Add insight for 16kb page ready#517
chromy wants to merge 1 commit into
mainfrom
chromy/2025-12-10-16kb-ready

Conversation

@chromy

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Dec 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.96907% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.16%. Comparing base (00e2fdf) to head (d8d7939).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
...pad/size/insights/android/sixteen_kb_page_ready.py95.65%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #517 +/- ##
==========================================
+ Coverage 80.91% 81.16% +0.25% 
==========================================
Files 164 166 +2 Lines 14213 14442 +229 Branches 1501 1516 +15 ==========================================
+ Hits 11500 11722 +222 - Misses 2144 2149 +5 - Partials 569 571 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pass


class SixteenKBPageReadyInsightResult(BaseModel):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this extend from FilesInsightResult? This way it will integrate more easily into the frontend code.

continue

logger.warning(
f"Android .so unaligned: {relative_path} section '{getattr(section, 'name', 'unknown')}' "

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using a stable log message + extras will make this a bit easier to search

return False

except Exception as e:
logger.error(f"Error analyzing ELF file {relative_path}: {e}")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: logger.exception

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@chromy@trevor-e