Uh oh!
There was an error while loading. Please reload this page.
feat(size): add standalone ELF analysis - #659
Conversation
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
📲 Install BuildsiOS
Android
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59bf93e. Configure here.
| if "::" not in qualified_name: | ||
| return CppNamespaceFunction(namespace="(global)", function_name=qualified_name) | ||
| namespace, function_name = qualified_name.rsplit("::", 1) | ||
| return CppNamespaceFunction(namespace=namespace, function_name=function_name) |
There was a problem hiding this comment.
Demangled C++ names split incorrectly
Medium Severity
Ownership is taken from demangled text by cutting at the first ( and the last ::. That breaks operator(), template arguments that contain ::, and demanglings that include a return type, so C++ groups and inferred ELF class owners land on the wrong names.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 59bf93e. Configure here.
| if "::" not in qualified_name: | ||
| return CppNamespaceFunction(namespace="(global)", function_name=qualified_name) | ||
| namespace, function_name = qualified_name.rsplit("::", 1) | ||
| return CppNamespaceFunction(namespace=namespace, function_name=function_name) |
There was a problem hiding this comment.
Apple analysis version not bumped
Medium Severity
C++ symbol grouping for Apple binaries now comes from demangled names instead of mangled nested-name components, which changes namespaces and function buckets. APPLE_ANALYSIS_VERSION stays at 1.2.1, so consumers still treat the new treemap layout as comparable to older reports.
Reviewed by Cursor Bugbot for commit 59bf93e. Configure here.
Summary
launchpad sizecommand.gnu_debuglinkDependencies
pyelftools==0.33for DWARF parsing; it is pure Python, has no transitive dependencies, and declares a public-domain license__cxa_demangleABI throughctypesinstead of adding a demangler packageTest plan
.venv/bin/python -m ruff check src tests.venv/bin/python -m ty check --error-on-warning srclaunchpad sizesmoke test against the clean-room ELF fixtureKnown limitation
The committed clean-room DWARF fixture has an
ET_DYNheader but no program headers because it is generated with the macOS cross-compiler without a Linux ELF linker. The parser is also smoke-tested against a fully linked stripped shared library.