Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

perf: avoid deep string copy - #213

Merged
JonasBa merged 1 commit into
mainfrom
avoid-deep-copy
Dec 6, 2023
Merged

perf: avoid deep string copy#213
JonasBa merged 1 commit into
mainfrom
avoid-deep-copy

Conversation

@anonrig

@anonriganonrig commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

std::string(char*) makes a deep copy of the string, but string.h provides us with strcmp C function to have equality checks between 2 different char pointers.

@anonrig
anonrig requested a review from JonasBaDecember 4, 2023 21:29
JonasBa
JonasBa approved these changes Dec 4, 2023
View reviewed changes

@JonasBaJonasBa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤝

@JonasBa
JonasBa merged commit 9608242 into mainDec 6, 2023
@JonasBa
JonasBa deleted the avoid-deep-copy branch December 6, 2023 13:06
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JonasBaJonasBaJonasBa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anonrig@JonasBa