Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 17, 2024. It is now read-only.
ref(deps) move all deps to dev deps - #218
Merged
Merged
Conversation
lforst
approved these changes
Dec 7, 2023
lforst
left a comment
There was a problem hiding this comment.
Just to make sure: There isn't anything actually depending on the lower-level packages like core or utils in this package right?
Also, it might be worth adding @sentry/node as a peer dep with some lower bound.
JonasBa
commented
Dec 7, 2023
ContributorAuthor
@lforst we use getMainCarrier from @sentry/core and a few utils exposed by the package. I'll add the @sentry/node peer dep to the first version that supported lifecycle hooks |
JonasBa
commented
Dec 7, 2023
ContributorAuthor
Added peer dependency to @sentry/node 7.44.1 which was the first version that supported hooks. |
anonrig
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our output is bundled by default in an effort to reduce startup perf, meaning our dependencies are not actually required and can be moved to devdeps