Uh oh!
There was an error while loading. Please reload this page.
Add the Client.install_asyncio_hook function. - #1134
Conversation
613df38 to
7439554CompareKentzo
commented
Nov 13, 2017
I'm not sure how to cause asyncio to call exception handler without 'exception' but with handle of future with the _source_traceback attribute set. |
Kentzo
commented
Nov 13, 2017
@ashwoods I used the 'exception' level instead of 'fatal' as handled errors don't explicitly cause interpreter to exit by default. Was it a good idea? |
Kentzo
commented
Nov 20, 2017
@ashwoods Is there anything I should change / fix? |
asvetlov
commented
Nov 21, 2017
The idea is strange for me. |
@asvetlov This change is to handle asyncio exceptions and unrelated to aiohttp transport. In one of the projects we are using this without raven-aiohttp. |
Kentzo
commented
Jan 25, 2018
@ashwoods I would love to address the issues if there are any |
Kentzo
commented
Mar 30, 2018
Anyone? I'm willing to fix any issues. |
ashwoods
commented
Mar 30, 2018
I haven't had time to look into context in the loop. Will breadcrumbs leak and be cleared? |
Kentzo
commented
May 30, 2018
@ashwoods What test would show it? |
Kentzo
commented
Aug 15, 2018
Re-opened to re-run CI tests. @ashwoods Any thoughts? |
asyncio needs special handling as its unhandled exceptions are consumed by logging and ignoring them.
@asvetlov Please take a look at the implementation and let me know if handling can be improved. I used implementation of
BaseEventLoop.default_exception_handleras a reference but didn't check all available context's keywords in all released versions of Python.