Uh oh!
There was an error while loading. Please reload this page.
feat: Upgrade to rrweb2 - #107
Merged
Merged
Conversation
…ded inputs (mutation vs snapshot)
Applying Justin's review suggestion
This currently adds a new API, `maskAttributesFn: (key: string, value: string, element: HTMLElement) => string`, that is used as a callback in `transformAttribute`. I prefer this API as it gives more flexibility for users (though it may need to pass the el node for most flexibility), but it is inconsistent with `maskTextFn` and `maskInputFn`. other options: * Rename this to something else (open to ideas) * Change this to pass value, and dom element (similar to MaskInputFn) to customize masking instead of decision maker of when to mask and introduce a simpler declarative API for what attributes to mask * ???
This patch adds the necessary configuration around our rrweb fork to publish our own `@sentry-internal/rr*` packages. This includes: - prefixing packages with `@sentry-internal` - adjusting licences and the readme - adding a craft config and a version bump script - adding artifact upload to our build&test GHA - adding the Sentry create release GHA
This is so input masking (maskAllInputs) is independent of `maskAllText`
This would allow you to broadly block elements and selectively unblock elements.
…as a textContent field and can be source of bugs
This would allow you to broadly block elements and selectively unblock elements.
Add an option to `assertSnapshots` to include scrolling as well for tests that is testing for it.
billyvg
marked this pull request as ready for review
September 20, 2023 15:58
billyvg
commented
Sep 20, 2023
MemberAuthor
I renamed the old sentry-v2 branch and recreated it from master and made it the default branch. Will use this PR to squash changes to a single commit - I think that'll be easier to maintain in the long run. |
mydea
approved these changes
Sep 21, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
I didn't review this PR in detail now, but seems good to me, the picked changes are all relevant & good 👍
billyvg added a commit
that referenced
this pull request
Oct 20, 2023
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io> Co-authored-by: mdellanoce <mdellanoce@users.noreply.github.com> Co-authored-by: Yun Feng <yun.feng0817@gmail.com> Co-authored-by: Francesco Novy <francesco.novy@sentry.io> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
billyvg added a commit
that referenced
this pull request
Jan 31, 2024
…stom elements (rrweb-io#1155) (#138) cherry-picks rrweb-io#1155 which was merged in our fork in #107 (prior to rrweb-io#1155 being merged). This results in only 2 small stylistic changes. Feat: Add support for replaying :defined pseudo-class of custom elements rrweb-io#1155 Co-authored-by: Yun Feng <yun.feng0817@gmail.com> Co-authored-by: Nafees Nehar <nafees87n@gmail.com> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
billyvg added a commit
that referenced
this pull request
Apr 26, 2024
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io> Co-authored-by: mdellanoce <mdellanoce@users.noreply.github.com> Co-authored-by: Yun Feng <yun.feng0817@gmail.com> Co-authored-by: Francesco Novy <francesco.novy@sentry.io> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows.
Cherry picks include the following upstream PRs:
ignoreSelectoroption rrweb-io/rrweb#1262Cherry picks from getsentry fork:
onMutationoption torecord#70