fix(snapshot): Fix CSS expansion of add CSS property - #223

Merged
billyvg merged 4 commits into
sentry-v2from
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged

fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from
fix-snapshot-fix-all-css-property-chrome-serialization

Conversation

@billyvg

@billyvgbillyvg commented Nov 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.

Ref https://github.com/getsentry/team-replay/issues/504

Example

CSS as defined by user

.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization

.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}

After fix

.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}

@billyvg
billyvg marked this pull request as ready for review November 26, 2024 21:02
@billyvg
billyvg requested a review from a teamNovember 26, 2024 21:02
chargome
chargome approved these changes Dec 2, 2024
View reviewed changes

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadpackages/rrweb-snapshot/src/utils.ts
* There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
* Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
*/
export function fixAllCssProperty(rule: CSSStyleRule) {

@chargomechargomeDec 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?

@billyvgbillyvgDec 4, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch

@billyvg
billyvg merged commit bc7d87b into sentry-v2Dec 4, 2024
@billyvg
billyvg deleted the fix-snapshot-fix-all-css-property-chrome-serialization branch December 4, 2024 21:24
@billyvgbillyvg mentioned this pull request Dec 5, 2024
Closed
billyvg added a commit to getsentry/sentry-javascript that referenced this pull request Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg mentioned this pull request Dec 5, 2024
Merged
billyvg added a commit to getsentry/sentry-javascript that referenced this pull request Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome mentioned this pull request Mar 26, 2026
Merged
chargome added a commit that referenced this pull request Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(snapshot): Fix CSS expansion of add CSS property - #223
Merged
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Dec 4, 2024
Merged
fix(snapshot): Fix CSS expansion of add CSS property#223
billyvg merged 4 commits into
sentry-v2from 
fix-snapshot-fix-all-css-property-chrome-serialization
Conversation
@billyvg
@billyvgbillyvg
commented
Nov 26, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds a workaround for this Chrome bug where the CSS property all gets expanded by Chrome and can potentially override user defined CSS.
Ref https://github.com/getsentry/team-replay/issues/504
Example
CSS as defined by user
.btn {
all: unset;
padding: 10px 15px;
}

After Chrome serialization
.btn {
color: unset;
font: unset;
font-palette: unset;
font-synthesis: unset;
forced-color-adjust: unset;
text-orientation: unset;
text-rendering: unset;
-webkit-font-smoothing: unset;
-webkit-locale: unset;
-webkit-text-orientation: unset;
-webkit-writing-mode: unset;
writing-mode: unset;
zoom: unset;
accent-color: unset;
place-content: unset;
place-items: unset;
place-self: unset;
alignment-baseline: unset;
animation-composition: unset;
animation: unset;
app-region: unset;
appearance: unset;
aspect-ratio: unset;
backdrop-filter: unset;
backface-visibility: unset;
background: unset;
background-blend-mode: unset;
baseline-shift: unset;
baseline-source: unset;
block-size: unset;
border-block: unset;
border: unset;
border-radius: unset;
border-collapse: unset;
border-end-end-radius: unset;
border-end-start-radius: unset;
border-inline: unset;
border-start-end-radius: unset;
border-start-start-radius: unset;
inset: unset;
box-shadow: unset;
box-sizing: unset;
break-after: unset;
break-before: unset;
break-inside: unset;
buffered-rendering: unset;
caption-side: unset;
caret-color: unset;
clear: unset;
clip: unset;
clip-path: unset;
clip-rule: unset;
color-interpolation: unset;
color-interpolation-filters: unset;
color-rendering: unset;
color-scheme: unset;
columns: unset;
column-fill: unset;
gap: unset;
column-rule: unset;
column-span: unset;
contain: unset;
contain-intrinsic-block-size: unset;
contain-intrinsic-size: unset;
contain-intrinsic-inline-size: unset;
container: unset;
content: unset;
content-visibility: unset;
counter-increment: unset;
counter-reset: unset;
counter-set: unset;
cursor: unset;
cx: unset;
cy: unset;
d: unset;
display: unset;
dominant-baseline: unset;
empty-cells: unset;
fill: unset;
fill-opacity: unset;
fill-rule: unset;
filter: unset;
flex: unset;
flex-flow: unset;
float: unset;
flood-color: unset;
flood-opacity: unset;
grid: unset;
grid-area: unset;
height: unset;
hyphenate-character: unset;
hyphenate-limit-chars: unset;
hyphens: unset;
image-orientation: unset;
image-rendering: unset;
initial-letter: unset;
inline-size: unset;
inset-block: unset;
inset-inline: unset;
isolation: unset;
letter-spacing: unset;
lighting-color: unset;
line-break: unset;
list-style: unset;
margin-block: unset;
margin: unset;
margin-inline: unset;
marker: unset;
mask: unset;
mask-type: unset;
math-depth: unset;
math-shift: unset;
math-style: unset;
max-block-size: unset;
max-height: unset;
max-inline-size: unset;
max-width: unset;
min-block-size: unset;
min-height: unset;
min-inline-size: unset;
min-width: unset;
mix-blend-mode: unset;
object-fit: unset;
object-position: unset;
object-view-box: unset;
offset: unset;
opacity: unset;
order: unset;
orphans: unset;
outline: unset;
outline-offset: unset;
overflow-anchor: unset;
overflow-clip-margin: unset;
overflow-wrap: unset;
overflow: unset;
overscroll-behavior-block: unset;
overscroll-behavior-inline: unset;
overscroll-behavior: unset;
padding-block: unset;
padding:10px15px;
padding-inline: unset;
page: unset;
page-orientation: unset;
paint-order: unset;
perspective: unset;
perspective-origin: unset;
pointer-events: unset;
position: unset;
quotes: unset;
r: unset;
resize: unset;
rotate: unset;
ruby-position: unset;
rx: unset;
ry: unset;
scale: unset;
scroll-behavior: unset;
scroll-margin-block: unset;
scroll-margin: unset;
scroll-margin-inline: unset;
scroll-padding-block: unset;
scroll-padding: unset;
scroll-padding-inline: unset;
scroll-snap-align: unset;
scroll-snap-stop: unset;
scroll-snap-type: unset;
scroll-timeline: unset;
scrollbar-gutter: unset;
shape-image-threshold: unset;
shape-margin: unset;
shape-outside: unset;
shape-rendering: unset;
size: unset;
speak: unset;
stop-color: unset;
stop-opacity: unset;
stroke: unset;
stroke-dasharray: unset;
stroke-dashoffset: unset;
stroke-linecap: unset;
stroke-linejoin: unset;
stroke-miterlimit: unset;
stroke-opacity: unset;
stroke-width: unset;
tab-size: unset;
table-layout: unset;
text-align: unset;
text-align-last: unset;
text-anchor: unset;
text-combine-upright: unset;
text-decoration: unset;
text-decoration-skip-ink: unset;
text-emphasis: unset;
text-emphasis-position: unset;
text-indent: unset;
text-overflow: unset;
text-shadow: unset;
text-size-adjust: unset;
text-transform: unset;
text-underline-offset: unset;
text-underline-position: unset;
white-space: unset;
touch-action: unset;
transform: unset;
transform-box: unset;
transform-origin: unset;
transform-style: unset;
transition: unset;
translate: unset;
user-select: unset;
vector-effect: unset;
vertical-align: unset;
view-timeline: unset;
view-timeline-inset: unset;
view-transition-name: unset;
visibility: unset;
border-spacing: unset;
-webkit-box-align: unset;
-webkit-box-decoration-break: unset;
-webkit-box-direction: unset;
-webkit-box-flex: unset;
-webkit-box-ordinal-group: unset;
-webkit-box-orient: unset;
-webkit-box-pack: unset;
-webkit-box-reflect: unset;
-webkit-highlight: unset;
-webkit-line-break: unset;
-webkit-line-clamp: unset;
-webkit-mask-box-image: unset;
-webkit-mask: unset;
-webkit-mask-composite: unset;
-webkit-print-color-adjust: unset;
-webkit-rtl-ordering: unset;
-webkit-ruby-position: unset;
-webkit-tap-highlight-color: unset;
-webkit-text-combine: unset;
-webkit-text-decorations-in-effect: unset;
-webkit-text-fill-color: unset;
-webkit-text-security: unset;
-webkit-text-stroke: unset;
-webkit-user-drag: unset;
-webkit-user-modify: unset;
widows: unset;
width: unset;
will-change: unset;
word-break: unset;
word-spacing: unset;
x: unset;
y: unset;
z-index: unset;
}
After fix
.btn {
all:unset;
padding-top:10px;
padding-right:15px;
padding-bottom:10px;
padding-left:15px;
}
@billyvg
billyvg
marked this pull request as ready for review
November 26, 2024 21:02
@billyvg
billyvg
requested a review
from a teamNovember 26, 2024 21:02
chargome
chargome
approved these changes
Dec 2, 2024
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadpackages/rrweb-snapshot/src/utils.ts
 * There is a bug in chrome (https://issues.chromium.org/issues/41416124) with the `all` property where we can't use `cssText` because it is wrong.
 * Instead, attempt to serialize the css string using `CSSStyleDeclaration`.
 */
export function fixAllCssProperty(rule: CSSStyleRule) {
@chargomechargomeDec 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need checks for !important in this function?
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch
@billyvg
billyvg
merged commit bc7d87b
into
sentry-v2Dec 4, 2024
@billyvg
billyvg
deleted the

fix-snapshot-fix-all-css-property-chrome-serialization

branch
December 4, 2024 21:24
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024

Closed

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0
7e0192d
Includes the following fixes:
- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
@billyvgbillyvg
mentioned this pull request
Dec 5, 2024
 Merged

billyvg added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
@billyvg
feat(replay): Upgrade rrweb packages to 2.30.0 (#14597)
666e668
Includes the following fixes:
- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
@chargomechargome
mentioned this pull request
Mar 26, 2026
 Merged

chargome added a commit
that referenced
this pull request
Apr 1, 2026
@chargome@claude
chore(rrweb): Replace fast-mhtml with inline MHTML parser (#274)
ad7243c
Remove the `fast-mhtml` dependency which was only used in one test
utility function (`packages/rrweb/test/utils.ts`) for parsing MHTML
snapshots in replayer E2E tests.
Replace with a minimal inline parser (~30 lines) that handles multipart
MIME boundary splitting and quoted-printable content decoding. All 47
replayer tests pass.
`fast-mhtml` pulled in `cheerio`, `express`, `undici`, `qs`, `bluebird`,
and `cookie` — a massive transitive tree for a simple test helper. This
removes ~584 lines from `yarn.lock`.
### Dependabot alerts resolved
**Fully resolved** (vulnerable package completely removed from
lockfile):
| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #166 | MEDIUM | `qs` | arrayLimit bypass allows DoS via memory
exhaustion |
| #183 | LOW | `qs` | arrayLimit bypass in comma parsing allows DoS |
**Partially resolved** (some entries removed, but package still exists
via other dependency chains):
| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #225, #224, #223, #222, #221, #170, #130, #112 | HIGH/MEDIUM/LOW |
`undici` | Still pulled in by `puppeteer` (Phase 3) |
| #100 | LOW | `cookie` | Still pulled in by `@sveltejs/kit` (Phase 5) |
closes
https://linear.app/getsentry/issue/SDK-1097/replace-fast-mhtml-9-alerts
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: chargome <chargome@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@chargome