Uh oh!
There was an error while loading. Please reload this page.
feat(rrweb): expose canvas manager subpath - #294
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/rrweb-canvas-manager-subpath
branch
from
May 11, 2026 20:46
c5e74ad to
7f75737Comparelogaretmforce-pushed
the
awad/rrweb-canvas-manager-subpath
branch
from
May 11, 2026 20:58
7f75737 to
1180d3cComparechargome
approved these changes
May 12, 2026
Uh oh!
There was an error while loading. Please reload this page.
logaretm added a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 15, 2026
This unblocks rolldown migration by adopting the just released rrweb version with getsentry/rrweb#294 This should reduce the bundle size increase coming out of rolldown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
CanvasManageras a subpath export, the reason for this is that therrwebpackage has some side effects along the export path that pins the whole graph.That prevents Rolldown's DCE from dropping it properly in sentry SDKs, blocking the adoption of rolldown. Rollup seemed to handle this properly.
I will release this once merged.