Uh oh!
There was an error while loading. Please reload this page.
fix: First record is checkout - #56
Closed
mydea wants to merge 1 commit into
Closed
Conversation
mydea added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 21, 2023
This relies on getsentry/rrweb#56 to be merged & released first.
billyvg
commented
Feb 21, 2023
Member
🤔 -- I wonder why rrweb did not have this in the first place? |
mydea
commented
Feb 21, 2023
MemberAuthor
Yes, I wondered the same. It is also that way in current master - I'll also create a PR there! |
billyvg
commented
Feb 21, 2023
Member
Yeah it would good if we can gain some insight first |
mydea
commented
Feb 21, 2023
MemberAuthor
ref rrweb-io#1150 |
mydea
commented
Feb 22, 2023
MemberAuthor
Closing this as this is apparently by design - see: rrweb-io#1150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to streamline our checkout check, it makes much more sense IMHO that the first emit is considered a checkout.