Skip to content

meta: add legal boilerplate to PR template - #3089

Merged
szokeasaurusrex merged 2 commits into
masterfrom
add_legal_boilerplate
Jan 27, 2026
Merged

meta: add legal boilerplate to PR template#3089
szokeasaurusrex merged 2 commits into
masterfrom
add_legal_boilerplate

Conversation

@dingsdax

@dingsdaxdingsdax commented Jan 15, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Added legal boilerplate to clarify contribution rights b/c CLI is FSL

@dingsdax
Add legal boilerplate to PR template
9f49806
Added legal boilerplate to clarify contribution rights b/c CLI is FSL
@dingsdax
dingsdax requested review from a team and szokeasaurusrex as code ownersJanuary 15, 2026 15:04
@dingsdaxdingsdax added the skip-changelog Apply this label to PRs that do not contain any user-facing changes label Jan 15, 2026
szokeasaurusrex
szokeasaurusrex approved these changes Jan 15, 2026
View reviewed changes

@szokeasaurusrexszokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just wonder whether we should have some CI check to ensure that this message is intact for non-employees and reject the PR otherwise. Could be helpful on other repos as well.

This would be a separate PR though

@szokeasaurusrexszokeasaurusrex changed the title fix: add legal boilerplate to PR templatemeta: add legal boilerplate to PR templateJan 15, 2026
@dingsdaxLinear

dingsdax commented Jan 15, 2026

Copy link
Copy Markdown
ContributorAuthor

I don't think this is necessary. Upon opening a PR an external contributor reads this language, there needs to be a conscious action to remove it. I don't think we have such a check for our other FSL licensed repos either.

@szokeasaurusrexLinear

szokeasaurusrex commented Jan 15, 2026

Copy link
Copy Markdown
Member

it is possible that they miss the template if they are opening the PR from gh CLI, which may become a more frequent use case with agentic coding workflows

@dingsdaxLinear

dingsdax commented Jan 15, 2026

Copy link
Copy Markdown
ContributorAuthor

still edge case territory for me. afaik GH CLI respect PR templates unless you override with "gh pr create --body", but that might be a nice addition to our Dangerfile … fine lets create a backlog issue

@szokeasaurusrex
szokeasaurusrex enabled auto-merge (squash) January 27, 2026 12:21
@szokeasaurusrex
szokeasaurusrex merged commit 9c1cd63 into masterJan 27, 2026
24 checks passed
@szokeasaurusrex
szokeasaurusrex deleted the add_legal_boilerplate branch January 27, 2026 12:24
@szokeasaurusrexszokeasaurusrex mentioned this pull request Jan 27, 2026
Open
CopilotAI mentioned this pull request Jan 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szokeasaurusrexszokeasaurusrexszokeasaurusrex approved these changes

Assignees

No one assigned

Labels

skip-changelogApply this label to PRs that do not contain any user-facing changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dingsdax@szokeasaurusrex