Uh oh!
There was an error while loading. Please reload this page.
docs(react-native): Document touch breadcrumb label fallbacks - #17650
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| The **label** is determined by the first available value from: | ||
| 1. `sentry-label` prop | ||
| 2. Custom `labelName` prop (if configured on the boundary) |
There was a problem hiding this comment.
m: Are 1 and 2 switched?
The diff from .../user-interaction-instrumentation.mdx suggests as much (unless I'm misreading?)
There was a problem hiding this comment.
Good catch 👍 The list order is correct since sentry-label is checked first in the code but the user-interaction-instrumentation.mdx is misleading. I updated with a00a0dd
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
0xadam-brown
left a comment
There was a problem hiding this comment.
I see Sentrybot has chimed in. I'm guessing the current wording is being precise where the bot isn't – approving on that basis. Obviously feel free to adjust if needed 👍
The full priority list is documented in touchevents.mdx. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
## DESCRIBE YOUR PR Updates React Native touch event docs to reflect that `accessibilityLabel`, `aria-label`, and `testID` are now automatically used as label fallbacks for touch breadcrumbs (added in [getsentry/sentry-react-native#6103](getsentry/sentry-react-native#6103)). **Changes:** - **`touchevents.mdx`**: Rewrote the "Tracking Specific Components" section to correctly distinguish between the **label** fallback chain (`sentry-label` > `labelName` > `accessibilityLabel` > `aria-label` > `testID`) and the **name** field (Babel annotation / `displayName`). Updated `labelName` option description. - **`user-interaction-instrumentation.mdx`**: Updated the label identification description to mention the full fallback chain. ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.) - [ ] Other deadline - [x] None: Not urgent, can wait up to 1 week+⚠️ Should be merged after getsentry/sentry-react-native#6103 is released ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…breadcrumbs (#17665) ## DESCRIBE YOUR PR Document the new text extraction from children feature for React Native touch breadcrumbs. - Add text content from children as item 6 in the label priority list - Document the `extractTextFromChildren` option - Add Alert about masking behavior (disabled when `maskAllText` is on, respects `Sentry.Mask`) - Update user interaction instrumentation docs to mention text children fallback **Depends on #17650** (label fallbacks docs) — based on that branch. **Companion SDK PR:** getsentry/sentry-react-native#6106 ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): - [ ] Other deadline: - [x] None: Not urgent, can wait up to 1 week+⚠️ Should be merged after getsentry/sentry-react-native#6106 is released ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
DESCRIBE YOUR PR
Updates React Native touch event docs to reflect that
accessibilityLabel,aria-label, andtestIDare now automatically used as label fallbacks for touch breadcrumbs (added in getsentry/sentry-react-native#6103).Changes:
touchevents.mdx: Rewrote the "Tracking Specific Components" section to correctly distinguish between the label fallback chain (sentry-label>labelName>accessibilityLabel>aria-label>testID) and the name field (Babel annotation /displayName). UpdatedlabelNameoption description.user-interaction-instrumentation.mdx: Updated the label identification description to mention the full fallback chain.IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST