Skip to content

docs(javascript): Document dataCollection option - #17986

Merged
s1gr1d merged 9 commits into
masterfrom
sig/dataCollection-option
Jun 9, 2026
Merged

docs(javascript): Document dataCollection option#17986
s1gr1d merged 9 commits into
masterfrom
sig/dataCollection-option

Conversation

@s1gr1d

@s1gr1ds1gr1d commented Jun 2, 2026

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

Merge after this is released: getsentry/sentry-javascript#21277

closesgetsentry/sentry-javascript#20939
closesgetsentry/sentry-javascript#21271

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@s1gr1d
s1gr1d requested a review from inventarSarahJune 2, 2026 11:37
@vercel

vercelBot commented Jun 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
sentry-docsReadyReadyPreview, CommentJun 9, 2026 9:02am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
develop-docsIgnoredIgnoredPreviewJun 9, 2026 9:02am

Request Review

@s1gr1d
s1gr1d requested review from chargome and cleptricJune 2, 2026 11:37
Comment threaddocs/platforms/javascript/common/configuration/options.mdx Outdated
@cleptric

Copy link
Copy Markdown
Member

Should also add this to https://docs.sentry.io/platforms/javascript/data-management/

@inventarSarahinventarSarah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me 👍

Will updating the other pages that mention sendDefaultPi be covered in a separate PR?
Let me know if I can support you with that.

Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated
@s1gr1d

Copy link
Copy Markdown
MemberAuthor

I updated the "Data Collected" page as well now: https://sentry-docs-git-sig-datacollection-option.sentry.dev/platforms/javascript/guides/nextjs/data-management/data-collected/

I also changed all code snippets that contained sendDefaultPii - so users don't get a deprecation warning when they paste the snippet.

Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated
Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated
Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated

@coolguyzonecoolguyzone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🏄‍♂️

@inventarSarahinventarSarah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏Looks great! Thanks for updating all these files :)

Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated
Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated
Comment threaddocs/platforms/javascript/common/data-management/data-collected/index.mdx Outdated

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise good to go!

Comment threaddocs/platforms/javascript/common/configuration/options.mdx Outdated
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@s1gr1d
s1gr1d enabled auto-merge (squash) June 9, 2026 08:51
@s1gr1d
s1gr1d merged commit 5b6ab57 into masterJun 9, 2026
20 checks passed
@s1gr1d
s1gr1d deleted the sig/dataCollection-option branch June 9, 2026 09:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update "Data Collected" docs with new behavior Update user docs for dataCollection

5 participants

@s1gr1d@cleptric@inventarSarah@chargome@coolguyzone