Skip to content

Update Java SDK docs to 3.0 - #2239

Merged
bruno-garcia merged 37 commits into
getsentry:masterfrom
maciejwalkowiak:sentry-java-3.0
Sep 30, 2020
Merged

Update Java SDK docs to 3.0#2239
bruno-garcia merged 37 commits into
getsentry:masterfrom
maciejwalkowiak:sentry-java-3.0

Conversation

@maciejwalkowiak

@maciejwalkowiakmaciejwalkowiak commented Sep 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Documentation and guides for Java SDK 3.0

@vercel
vercelBot temporarily deployed to Preview September 10, 2020 09:43 Inactive
@vercel

vercelBot commented Sep 10, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/6rcol1kr8/sentry.dev
✅ Preview: https://sentry-docs-git-fork-maciejwalkowiak-sentry-java-30.sentry.dev

@vercel
vercelBot temporarily deployed to Preview September 15, 2020 13:16 Inactive
@bruno-garcia

bruno-garcia commented Sep 30, 2020

Copy link
Copy Markdown
Member

Maybe worth hidding the generic breadcrumbs doc too: https://sentry-docs-git-fork-maciejwalkowiak-sentry-java-30.sentry.dev/platforms/java/enriching-events/breadcrumbs/

Since Java has its own. Right now 2 breadcrumbs items show on the list

bruno-garcia
bruno-garcia approved these changes Sep 30, 2020
View reviewed changes

@bruno-garciabruno-garcia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some improvements.
But it LGTM.

We can merge, release the SDK and iterate improving things.

@vercel
vercelBot temporarily deployed to Preview September 30, 2020 12:57 Inactive
@maciejwalkowiak@bruno-garcia
Apply suggestions from code review
06cbd0f
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@vercel
vercelBot temporarily deployed to Preview September 30, 2020 12:59 Inactive
@vercel
vercelBot temporarily deployed to Preview September 30, 2020 13:00 Inactive
@maciejwalkowiak

maciejwalkowiak commented Sep 30, 2020

Copy link
Copy Markdown
ContributorAuthor

The problem with "Legacy" docs placement still remains. Since it's added to "Common" section, each guide has now a legacy section and you can end up on the site like Home > Platforms > Java > Spring Boot > Legacy SDK (1.7) > log4j 2.x

image

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/includes/configuration/config-intro/java.mdx Outdated
```

```kotlin {tabTitle:Kotlin}
import io.sentry.SentryOptions.BeforeBreadcrumbCallback

@marandanetomarandanetoSep 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? its not using it

@maciejwalkowiakmaciejwalkowiakSep 30, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/includes/configuration/drain-example/java.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/common/legacy/configuration/index.mdx
Option names in the DSN exactly match the examples given below. For example, to enable sampling if you are setting your DSN via the environment:

```bash
SENTRY_DSN={DSN}/1?sample.rate=0.75 java -jar app.jar

@marandanetomarandanetoSep 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SENTRY_DSN={DSN}/1?sample.rate=0.75 java -jar app.jar
SENTRY_DSN=___PUBLIC_DSN___/1?sample.rate=0.75 java -jar app.jar

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/guides/logback/index.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/guides/logback/index.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/guides/logback/index.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/guides/logback/index.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/common/legacy/logging/index.mdx Outdated
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
Comment threadsrc/platforms/java/common/legacy/configuration/index.mdx
@maciejwalkowiak@marandaneto
Apply suggestions from code review
60ef121
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@vercel
vercelBot temporarily deployed to Preview September 30, 2020 14:52 Inactive
@bruno-garcia

bruno-garcia commented Sep 30, 2020

Copy link
Copy Markdown
Member

Let's merge and iterate over this?!

@bruno-garcia
bruno-garcia merged commit 6685fbf into getsentry:masterSep 30, 2020
ajjindal pushed a commit that referenced this pull request Sep 30, 2020
@maciejwalkowiak@PeloWriter
@bruno-garcia@marandanetoAJ
Update Java SDK docs to 3.0 (#2239)
7c36085
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
NisanthanNanthakumar pushed a commit that referenced this pull request Oct 1, 2020
@maciejwalkowiak@PeloWriter
@bruno-garcia@marandanetoNisanthan Nanthakumar
Update Java SDK docs to 3.0 (#2239)
f785c6b
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 16, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garciabruno-garciabruno-garcia approved these changes
+2 more reviewers
@marandanetomarandanetomarandaneto left review comments
@PeloWriterPeloWriterPeloWriter left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maciejwalkowiak@bruno-garcia@marandaneto@PeloWriter