Skip to content

feat(react-native): React Native auto performance docs - #2908

Merged
jennmueng merged 4 commits into
masterfrom
jenn/rn-auto-tracing
Jan 22, 2021
Merged

feat(react-native): React Native auto performance docs#2908
jennmueng merged 4 commits into
masterfrom
jenn/rn-auto-tracing

Conversation

@jennmueng

@jennmuengjennmueng commented Jan 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

React-Native specific override for performance auto instrumentation docs.

Note that this does not mention the configuration options for the routing instrumentations such as shouldSendTransaction as the API could change to use beforeNavigate in a following version following getsentry/sentry-javascript#3192.

@vercel

vercelBot commented Jan 16, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/96h3g5gj1/sentry.dev
✅ Preview: https://sentry-docs-git-jenn-rn-auto-tracing.sentry.dev

bruno-garcia
bruno-garcia reviewed Jan 16, 2021
View reviewed changes
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
@jennmueng
jennmueng marked this pull request as ready for review January 21, 2021 17:47
PeloWriter
PeloWriter approved these changes Jan 21, 2021
View reviewed changes

@PeloWriterPeloWriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
Comment threadsrc/platforms/common/performance/capturing/automatic.mdx Outdated
@jennmueng@PeloWriter
ref: Code review suggestions
00761f0
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
@jennmuengjennmueng changed the title feat: React Native auto performance docsfeat(react-native): React Native auto performance docsJan 22, 2021
@jennmueng
jennmueng merged commit c7a4107 into masterJan 22, 2021
@jennmueng
jennmueng deleted the jenn/rn-auto-tracing branch January 22, 2021 16:26
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lobsterkatielobsterkatieAwaiting requested review from lobsterkatie
@bruno-garciabruno-garciaAwaiting requested review from bruno-garcia
1 more reviewer
@PeloWriterPeloWriterPeloWriter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jennmueng@bruno-garcia@PeloWriter