Skip to content

ref: Node DB auto-instrumentation docs - #3563

Merged
HazAT merged 3 commits into
masterfrom
db-integrations
May 18, 2021
Merged

ref: Node DB auto-instrumentation docs#3563
HazAT merged 3 commits into
masterfrom
db-integrations

Conversation

@kamilogorek

@kamilogorekkamilogorek commented May 11, 2021

Copy link
Copy Markdown
Contributor

@kamilogorek
kamilogorek requested review from a team, ahmedetefy and rhcarvalho and removed request for a teamMay 11, 2021 07:41
@vercel

vercelBot commented May 11, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/5T2jWJpGu1NfB9KhQqU2tCoU8ZQN
✅ Preview: https://sentry-docs-git-db-integrations.sentry.dev

HazAT
HazAT approved these changes May 11, 2021
View reviewed changes

@HazATHazAT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Let's merge this once we released the SDK

@kamilogorekkamilogorek mentioned this pull request May 11, 2021
Merged
@rhcarvalho
rhcarvalho removed their request for review May 11, 2021 08:44
lobsterkatie
lobsterkatie previously requested changes May 11, 2021
View reviewed changes

@lobsterkatielobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also document a) how to configure an auto-enabled integration, and b) what options there are to configure for each?

Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
@kamilogorek@lobsterkatie
Apply suggestions from code review
b9304f4
Co-authored-by: Katie Byers <katie.byers@sentry.io>
PeloWriter
PeloWriter approved these changes May 11, 2021
View reviewed changes

@PeloWriterPeloWriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits to smooth.

Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
Comment threadsrc/platforms/node/common/performance/database.mdx Outdated
@kamilogorek@PeloWriter
Apply suggestions from code review
26d2210
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
@HazAT
HazAT merged commit ff6d05a into masterMay 18, 2021
@HazAT
HazAT deleted the db-integrations branch May 18, 2021 21:38
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HazATHazATHazAT approved these changes
@lobsterkatielobsterkatielobsterkatie left review comments
+2 more reviewers
@ahmedetefyahmedetefyahmedetefy approved these changes
@PeloWriterPeloWriterPeloWriter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kamilogorek@HazAT@ahmedetefy@lobsterkatie@PeloWriter