Skip to content

feat(js): Document new bundle varieties - #4842

Merged
lobsterkatie merged 3 commits into
masterfrom
kmclb-document-debug-bundles
Mar 22, 2022
Merged

feat(js): Document new bundle varieties#4842
lobsterkatie merged 3 commits into
masterfrom
kmclb-document-debug-bundles

Conversation

@lobsterkatie

@lobsterkatielobsterkatie commented Mar 16, 2022•
edited
Loading

Copy link
Copy Markdown
Member

A number of PRs (#4674, #4699, #4718) have recently added to the bundles available for use on the CDN. This documents the new options, and does some general wordsmithing on the page.

@vercel

vercelBot commented Mar 16, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/FVQpRD87D85bgyVPGqZaYPRDmgUU
✅ Preview: https://sentry-docs-git-kmclb-document-debug-bundles.sentry.dev

imatwawana
imatwawana approved these changes Mar 16, 2022
View reviewed changes

@imatwawanaimatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly very minor wording changes, and I made one suggestion for formatting.

Comment threadsrc/platforms/javascript/common/install/cdn.mdx Outdated
Comment threadsrc/platforms/javascript/common/install/cdn.mdx Outdated
Comment threadsrc/platforms/javascript/common/install/cdn.mdx Outdated
Lms24
Lms24 approved these changes Mar 17, 2022
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and well-explained to me. Great examples for the naming scheme.

@lobsterkatie
lobsterkatieforce-pushed the kmclb-document-debug-bundles branch from 9c73ba1 to 9fa8752CompareMarch 22, 2022 18:59
@lobsterkatie
lobsterkatie merged commit 653f750 into masterMar 22, 2022
@lobsterkatie
lobsterkatie deleted the kmclb-document-debug-bundles branch March 22, 2022 19:12
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24Lms24Lms24 approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@lforstlforstAwaiting requested review from lforst
+1 more reviewer
@imatwawanaimatwawanaimatwawana approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie@Lms24@imatwawana