Skip to content

clarify definition of events and attachments - #5106

Closed
imatwawana wants to merge 4 commits into
masterfrom
fix/fix-quota-mgmt-transactions-events-attachments
Closed

clarify definition of events and attachments#5106
imatwawana wants to merge 4 commits into
masterfrom
fix/fix-quota-mgmt-transactions-events-attachments

Conversation

@imatwawana

@imatwawanaimatwawana commented Jun 1, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Clarifies the definition of attachments as not events in several places

Replicated work on Transaction Quota Mgmt on PR 5114 to unblock that

@vercel

vercelBot commented Jun 1, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
sentry-docs✅ Ready (Inspect)Visit PreviewJun 3, 2022 at 8:14PM (UTC)

iker-barriocanal
iker-barriocanal reviewed Jun 3, 2022
View reviewed changes
Comment threadsrc/docs/product/accounts/pricing.mdx Outdated
Comment threadsrc/docs/product/accounts/quotas/index.mdx Outdated
imatwawanaand others added 2 commits June 3, 2022 10:10
@imatwawana@iker-barriocanal
fix definition of events
97e79d6
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
@imatwawana@iker-barriocanal
fixing events and attachments wording
a356a8e
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
@imatwawana

imatwawana commented Jun 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Since we're still waiting on clarification from the product folks about the attachments stuff, I'm going to open a new PR for the just the changes to the manage-transaction-quota.mdx file and remove those updates from this PR. That's a separate issue and I want to get that fix in sooner than later.

@imatwawanaimatwawana changed the title fix transaction quota content and clarify attachmentsclarify definition of events and attachmentsJun 3, 2022
@github-actions

github-actionsBot commented Jun 25, 2022

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@imatwawanaimatwawana mentioned this pull request Aug 16, 2022
Merged
@imatwawana

imatwawana commented Aug 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Closing this PR. There are too many merge conflicts because of significant changes to Quota Management and Pricing docs. Many of the issues raised on this PR were resolved on other PRs and the remaining ones are resolved on #5434.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 1, 2022
@stephanie-anderson
stephanie-anderson deleted the fix/fix-quota-mgmt-transactions-events-attachments branch February 23, 2024 10:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@iker-barriocanaliker-barriocanaliker-barriocanal left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imatwawana@iker-barriocanal