Skip to content

Add Remix SDK docs - #5247

Merged
AbhiPrasad merged 7 commits into
getsentry:masterfrom
onurtemizkan:remix-sdk-docs
Jul 15, 2022
Merged

Add Remix SDK docs#5247
AbhiPrasad merged 7 commits into
getsentry:masterfrom
onurtemizkan:remix-sdk-docs

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

@vercel

vercelBot commented Jul 4, 2022

Copy link
Copy Markdown

@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

vladanpaunovic
vladanpaunovic reviewed Jul 4, 2022
View reviewed changes

@vladanpaunovicvladanpaunovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use these docs PR for us to discuss the overall developer experience of using the @sentry/remix SDK and ways to improve/simplify it.

Let's see how many of the ideas I have had here are actually doable. :)

Comment threadsrc/includes/getting-started-config/javascript.remix.mdx
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/upload/primer/javascript.remix.mdx Outdated
@vercel

vercelBot commented Jul 5, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
sentry-docs✅ Ready (Inspect)Visit PreviewJul 5, 2022 at 2:15PM (UTC)

imatwawana
imatwawana reviewed Jul 5, 2022
View reviewed changes

@imatwawanaimatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording and formatting/style edits.

Comment threadsrc/includes/capture-error/javascript.remix.mdx Outdated
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/getting-started-config/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/overview/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/overview/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/overview/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/upload/primer/javascript.remix.mdx Outdated
Comment threadsrc/includes/sourcemaps/upload/primer/javascript.remix.mdx Outdated
vladanpaunovic
vladanpaunovic reviewed Jul 8, 2022
View reviewed changes

@vladanpaunovicvladanpaunovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's just wait for getsentry/sentry-javascript#5365 to be merged and then make sure to communicate only withSentry and remove all instances of withSentryRouteTracing

onurtemizkanand others added 3 commits July 8, 2022 13:51
@AbhiPrasadAbhiPrasad mentioned this pull request Jul 8, 2022
Closed
26 tasks
AbhiPrasad
AbhiPrasad approved these changes Jul 15, 2022
View reviewed changes
Comment threadsrc/includes/getting-started-primer/javascript.remix.mdx Outdated
@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) July 15, 2022 13:24
@AbhiPrasad
AbhiPrasad disabled auto-merge July 15, 2022 13:24
@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) July 15, 2022 13:24
@AbhiPrasad
AbhiPrasad merged commit eec1fb3 into getsentry:masterJul 15, 2022
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 31, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@smeubanksmeubankAwaiting requested review from smeubank
3 more reviewers
@vladanpaunovicvladanpaunovicvladanpaunovic left review comments
@imatwawanaimatwawanaimatwawana left review comments
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@onurtemizkanonurtemizkan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onurtemizkan@AbhiPrasad@vladanpaunovic@imatwawana