Skip to content

feat(nextjs): Add transpileClientSDK option and build config page - #5350

Merged
lobsterkatie merged 4 commits into
masterfrom
kmclb-add-nextjs-transpileClientSDK-option
Jul 28, 2022
Merged

feat(nextjs): Add transpileClientSDK option and build config page#5350
lobsterkatie merged 4 commits into
masterfrom
kmclb-add-nextjs-transpileClientSDK-option

Conversation

@lobsterkatie

@lobsterkatielobsterkatie commented Jul 27, 2022•
edited
Loading

Copy link
Copy Markdown
Member

In getsentry/sentry-javascript#5472, a transpileClientSDK option was added to the nextjs SDK to force SDK code to be transpiled along with other app code, primarily for the use of folks wanting to use the SDK in older browsers without support for ES6 or ES6+ features like object spread. This documents that option by:

  • Adding a section to the manual setup page (which is where other build-time options live)
  • Adding a new 'Build Options' page redirecting people to the relevant section of of the manual setup page, for greater discoverability
  • Adding a nextjs-specific include to a new legacy browser support section on the Troubleshooting page. (A generic include has also been added for the non-nextjs JS docs, detailing how to do manually what the added option causes the nextjs SDK to do automatically.)

@vercel

vercelBot commented Jul 27, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
sentry-docs✅ Ready (Inspect)Visit PreviewJul 28, 2022 at 1:59PM (UTC)

@lobsterkatielobsterkatie mentioned this pull request Jul 27, 2022
Merged
@lobsterkatielobsterkatie mentioned this pull request Jul 27, 2022
Closed
5 tasks
AbhiPrasad
AbhiPrasad approved these changes Jul 27, 2022
View reviewed changes

@AbhiPrasadAbhiPrasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical stuff ✅

Comment threadsrc/platforms/javascript/common/troubleshooting/index.mdx Outdated
@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-nextjs-transpileClientSDK-option branch 2 times, most recently from 26855e3 to 7d3cb25CompareJuly 27, 2022 20:36
@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-nextjs-transpileClientSDK-option branch from 7d3cb25 to 131d288CompareJuly 27, 2022 21:02
imatwawana
imatwawana approved these changes Jul 28, 2022
View reviewed changes

@imatwawanaimatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comma and posed a structural question, but otherwise LGTM!

Comment threadsrc/platforms/javascript/common/troubleshooting/index.mdx Outdated
Comment threadsrc/platforms/javascript/common/troubleshooting/index.mdx Outdated
@lobsterkatie@imatwawana
Add comma
996c0b8
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@lobsterkatie
lobsterkatie enabled auto-merge (squash) July 28, 2022 13:42
@lobsterkatie
lobsterkatie merged commit 9f89eae into masterJul 28, 2022
@lobsterkatie
lobsterkatie deleted the kmclb-add-nextjs-transpileClientSDK-option branch July 28, 2022 13:45
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24Lms24Awaiting requested review from Lms24
2 more reviewers
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
@imatwawanaimatwawanaimatwawana approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie@AbhiPrasad@imatwawana