Skip to content

Remove references to manually use withSentry from Next.js docs - #5543

Merged
lforst merged 2 commits into
masterfrom
lforst-remove-with-sentry-references
Oct 10, 2022
Merged

Remove references to manually use withSentry from Next.js docs#5543
lforst merged 2 commits into
masterfrom
lforst-remove-with-sentry-references

Conversation

@lforst

@lforstlforst commented Sep 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: getsentry/sentry-javascript#5505

Removes all references and instructions to use withSentry from the docs, under the assumption that users will use our new auto-wrapping functionality of Next.js data fetching methods and API routes instead.

@vercel

vercelBot commented Sep 22, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
sentry-docs✅ Ready (Inspect)Visit PreviewOct 10, 2022 at 11:29AM (UTC)

@lforstlforst changed the title Remove references to manually use withSentry from Next.js docsRemove references to manually use withSentry from Next.js docsSep 22, 2022
@lforstlforst mentioned this pull request Sep 22, 2022
Closed
43 tasks
@lforst
lforstforce-pushed the lforst-remove-with-sentry-references branch 2 times, most recently from 2ed28e2 to 86ea721CompareSeptember 22, 2022 11:52
imatwawana
imatwawana reviewed Sep 22, 2022
View reviewed changes

@imatwawanaimatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some styling edits

Comment threadsrc/platform-includes/performance/connect-services/javascript.mdx Outdated
Comment threadsrc/platform-includes/performance/what-instrumentation-provides/javascript.nextjs.mdx Outdated
Comment threadsrc/platform-includes/performance/what-instrumentation-provides/javascript.nextjs.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
@lforst

lforst commented Oct 10, 2022

Copy link
Copy Markdown
ContributorAuthor

Sorry for tagging everybody 😬 Git be hard sometimes

@lforst
lforstforce-pushed the lforst-remove-with-sentry-references branch from b712f5c to d5f58efCompareOctober 10, 2022 10:58
AbhiPrasad
AbhiPrasad approved these changes Oct 10, 2022
View reviewed changes
Comment threadsrc/platforms/javascript/guides/nextjs/manual-setup.mdx Outdated
Luca Forstner@AbhiPrasad
Apply suggestion
3f48f68
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@lforst
lforst marked this pull request as ready for review October 10, 2022 11:07
@lforst
lforst merged commit 6234bcb into masterOct 10, 2022
@lforst
lforst deleted the lforst-remove-with-sentry-references branch October 10, 2022 13:57
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@imatwawanaimatwawanaimatwawana left review comments
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@AbhiPrasad@imatwawana