Uh oh!
There was an error while loading. Please reload this page.
feat: Add docs for custom browser tracing routing instrumentation - #9113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| }); | ||
| // Somewhere, instrument your router like this: | ||
| myRouter.on("routeChange", (route) => { |
There was a problem hiding this comment.
We should add a note about setting correct route name for pageload as well, we want to avoid un-paramaterized transactions.
There was a problem hiding this comment.
I guess this is mostly about updating the pageload span, right? 🤔 or should we document how to emit a pageload span?
There was a problem hiding this comment.
yeah updating the pageload span, I think most frameworks will be fine with emitting pageload as soon as possible.
There was a problem hiding this comment.
I opened a PR: getsentry/sentry-javascript#10633 to make this easier, as documenting this showed that there is def. room for improvement there!
| }); | ||
| ``` | ||
| <PlatformContent includePath="performance/automatic-instrumentation-custom-routing" /> No newline at end of file |
There was a problem hiding this comment.
l: should this documentation live under "Automatic Instrumentation"? Isn't this rather fitting for "Custom Instrumentation"?
I guess there's a case for both, given we're mentioning browserTracingIntegration directly above but maybe it's enough to link to custom from the "Autmatic Instrumentation" page
There was a problem hiding this comment.
yeah, IMHO I'd generally restructure this a bit in a follow up - we should rethink this with a bit of time! Currently that's basically the "browser tracing" page, in reality, even though the name is not necessarily clear on that.
mydea
commented
Feb 13, 2024
I have updated this based on the changes in v7.101.0. Now it is a "full" example including updating the pageload span. |
lizokm
left a comment
There was a problem hiding this comment.
LGTM, just a few small tweaks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Liza Mock <liza.mock@sentry.io>
This fixes one forgotten line in the react docs, and adds a section to react & browser auto-instrument docs on how to implement your own navigation instrumentation using the new APIs.