Uh oh!
There was an error while loading. Please reload this page.
fix: Unsampled Transactions no longer propagate empty trace headers - #5293
fix: Unsampled Transactions no longer propagate empty trace headers#5293Flash0ver wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #5293 +/- ##
==========================================
- Coverage 74.13% 73.48% -0.65%
==========================================
Files 508 494 -14 Lines 18320 17913 -407 Branches 3584 3494 -90 ==========================================
- Hits 13581 13164 -417 - Misses 3864 3885 +21 + Partials 875 864 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| var carrier = new Dictionary<string, string>() | ||
| { | ||
| { "sentry-trace", "00000000000000000000000000000000-1000000000000000-1" } | ||
| }; |
There was a problem hiding this comment.
question: is this a valid test case?
This test fails on Windows on net48.
Is this a valid test case to add (no changes in related production code)?
There was a problem hiding this comment.
Would need to do some digging to confirm, but my gut tells me no.... I don't think we propagate empty trace ids (I seem to recall these get filtered or handled specially when parsing the incoming trace header).
This is a follow-up to
#4302 applied the fix to
Sentry.AspNetCoreonly.Changes
This changeset is
Sentry.AspNetas wellSentry.OpenTelemetry/Sentry.OpenTelemetry.Exporterfor existing related behavior that is intentionally left unchanged