Uh oh!
There was an error while loading. Please reload this page.
feat: Manually capturing user feedback - #559
Conversation
lucas-zimerman
commented
Oct 26, 2020
🤔 Should I edit the changelog? |
bruno-garcia
left a comment
There was a problem hiding this comment.
Thanks for contributing again Lucas! I left a few comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bruno-garcia
commented
Oct 27, 2020
Yes please |
Uh oh!
There was an error while loading. Please reload this page.
…lock from sentryclient, renamed sentryuserfeedback) and added more unit tests.
Codecov Report
@@ Coverage Diff @@## main #559 +/- ##
==========================================
- Coverage 85.06% 84.85% -0.22%
==========================================
Files 142 143 +1 Lines 3462 3513 +51 Branches 775 784 +9 ==========================================
+ Hits 2945 2981 +36 - Misses 310 323 +13 - Partials 207 209 +2
Continue to review full report at Codecov.
|
weird, the test worked fine on my computer. public static void CaptureUserFeedback(SentryId eventId, string email, string comments, string? name = null) EDIT: |
bruno-garcia
left a comment
There was a problem hiding this comment.
Almost there! Left a couple notes.
Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… and minor requested changes.
bruno-garcia
left a comment
There was a problem hiding this comment.
Beautiful stuff!! Thanks a lot @lucas-zimerman
Based on getsentry/sentry-cocoa#805
This PR implements the CaptureUserFeedback so users can associate user feedback to an event.
Fixes#153