Skip to content

feat: Manually capturing User Feedback - #1017

Merged
philipphofmann merged 5 commits into
mainfrom
feat/user-feedback
Oct 29, 2020
Merged

feat: Manually capturing User Feedback#1017
philipphofmann merged 5 commits into
mainfrom
feat/user-feedback

Conversation

@philipphofmann

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The SDK now provides a method captureUserFeedback to associate user
feedback to an event.

💡 Motivation and Context

We want to bring this feature to our users.

💚 How did you test it?

Unit tests and simulator.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Add this to docs.

The SDK now provides a method captureUserFeedback to associate user
feedback to an event.
@codecov-io

codecov-io commented Oct 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1017 into main will increase coverage by 0.32%.
The diff coverage is 83.82%.

Impacted file tree graph

@@ Coverage Diff @@## main #1017 +/- ##
============================================
+ Coverage 71.61% 71.94% +0.32% - Complexity 1299 1319 +20 
============================================
Files 134 135 +1 Lines 4731 4808 +77 Branches 490 491 +1 ============================================
+ Hits 3388 3459 +71 - Misses 1087 1091 +4 - Partials 256 258 +2 
Impacted FilesCoverage ΔComplexity Δ
sentry/src/main/java/io/sentry/HubAdapter.java10.20% <0.00%> (-0.44%)4.00 <0.00> (ø)
sentry/src/main/java/io/sentry/IHub.java83.33% <ø> (ø)6.00 <0.00> (ø)
sentry/src/main/java/io/sentry/ISentryClient.java88.88% <ø> (ø)9.00 <0.00> (ø)
sentry/src/main/java/io/sentry/NoOpHub.java55.17% <0.00%> (-1.98%)16.00 <0.00> (ø)
...ntry/src/main/java/io/sentry/NoOpSentryClient.java55.55% <0.00%> (-6.95%)5.00 <0.00> (ø)
sentry/src/main/java/io/sentry/NoOpSerializer.java36.36% <0.00%> (-8.09%)4.00 <0.00> (ø)
sentry/src/main/java/io/sentry/Hub.java65.61% <71.42%> (+0.55%)61.00 <2.00> (+2.00)
...ry/src/main/java/io/sentry/SentryEnvelopeItem.java85.71% <88.88%> (+0.93%)15.00 <2.00> (+2.00)
sentry/src/main/java/io/sentry/GsonSerializer.java100.00% <100.00%> (ø)14.00 <2.00> (+2.00)
sentry/src/main/java/io/sentry/Sentry.java44.80% <100.00%> (+0.89%)18.00 <1.00> (+1.00)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd941d7...1764acf. Read the comment docs.

Comment threadsentry/src/main/java/io/sentry/SentryItemType.java Outdated
Comment threadsentry/src/main/java/io/sentry/UserFeedback.java
Comment threadsentry/src/test/java/io/sentry/GsonSerializerTest.kt
Comment threadsentry/src/test/java/io/sentry/GsonSerializerTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/HubTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/HubTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/HubTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/HubTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/HubTest.kt
Comment threadsentry/src/test/java/io/sentry/SentryClientTest.kt Outdated
Comment threadsentry/src/test/java/io/sentry/SentryClientTest.kt Outdated

@marandanetomarandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few comments but other than that looks good :) well done!

@philipphofmann
philipphofmann merged commit 7618ab2 into mainOct 29, 2020
@philipphofmann
philipphofmann deleted the feat/user-feedback branch October 29, 2020 16:57
@philipphofmannphilipphofmann linked an issue Oct 30, 2020 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Sentry User Feedback

3 participants

@philipphofmann@codecov-io@marandaneto