Uh oh!
There was an error while loading. Please reload this page.
Feat/profiling/android - #1973
Merged
Merged
Conversation
* Added a transaction profiler (noOp on java sdk) that starts/stops android profiling when a transaction starts or is finished * Added a new envelope item type "profile", generated using android trace file. Its payload is a json represented by ProfilingTraceData * SentryExecutorService now uses a ScheduledExecutorService to allow the schedule() method * Added "profilingTracesDirPath" and "profilingTracesIntervalMillis" to SentryAndroidOptions * Added "profilingEnabled", "maxTraceFileSize" and "transactionProfiler" to SentryOptions * Added io.sentry.traces.profiling.enable to manifest options * Profiling is disabled by default * Profiling traces directory's content is deleted in the background when the options are initialized
* Added a transaction profiler (noOp on java sdk) that starts/stops android profiling when a transaction starts or is finished * Added a new envelope item type "profile", generated using android trace file. Its payload is a json represented by ProfilingTraceData * SentryExecutorService now uses a ScheduledExecutorService to allow the schedule() method * Added "profilingTracesDirPath" and "profilingTracesIntervalMillis" to SentryAndroidOptions * Added "profilingEnabled", "maxTraceFileSize" and "transactionProfiler" to SentryOptions * Added io.sentry.traces.profiling.enable to manifest options * Profiling is disabled by default * Profiling traces directory's content is deleted in the background when the options are initialized
added ser/deser logic to ProfilingTraceData (+ tests)
…t/profiling/android # Conflicts: # CHANGELOG.md # gradle.properties # sentry-android-core/src/test/java/io/sentry/android/core/AndroidTransactionProfilerTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidOptionsTest.kt # sentry/api/sentry.api # sentry/src/main/java/io/sentry/ProfilingTraceData.java # sentry/src/main/java/io/sentry/SentryEnvelopeItem.java # sentry/src/test/java/io/sentry/HubTest.kt # sentry/src/test/java/io/sentry/SentryClientTest.kt # sentry/src/test/java/io/sentry/SentryEnvelopeItemTest.kt # sentry/src/test/java/io/sentry/SentryTracerTest.kt
* Added a transaction profiler (noOp on java sdk) that starts/stops android profiling when a transaction starts or is finished * Added a new envelope item type "profile", generated using android trace file. Its payload is a json represented by ProfilingTraceData * SentryExecutorService now uses a ScheduledExecutorService to allow the schedule() method * Added "profilingTracesDirPath" and "profilingTracesIntervalMillis" to SentryAndroidOptions * Added "profilingEnabled", "maxTraceFileSize" and "transactionProfiler" to SentryOptions * Added io.sentry.traces.profiling.enable to manifest options * Profiling is disabled by default * Profiling traces directory's content is deleted in the background when the options are initialized
added ser/deser logic to ProfilingTraceData (+ tests)
* Added a transaction profiler (noOp on java sdk) that starts/stops android profiling when a transaction starts or is finished * Added a new envelope item type "profile", generated using android trace file. Its payload is a json represented by ProfilingTraceData * SentryExecutorService now uses a ScheduledExecutorService to allow the schedule() method * Added "profilingTracesDirPath" and "profilingTracesIntervalMillis" to SentryAndroidOptions * Added "profilingEnabled", "maxTraceFileSize" and "transactionProfiler" to SentryOptions * Added io.sentry.traces.profiling.enable to manifest options * Profiling is disabled by default * Profiling traces directory's content is deleted in the background when the options are initialized
…t/profiling/android # Conflicts: # CHANGELOG.md # gradle.properties # sentry-android-core/api/sentry-android-core.api # sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java # sentry-android-core/src/main/java/io/sentry/android/core/IBuildInfoProvider.java # sentry-android-core/src/test/java/io/sentry/android/core/ActivityLifecycleIntegrationTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt # sentry-apollo/src/test/java/io/sentry/apollo/SentryApolloInterceptorTest.kt # sentry-spring/src/test/kotlin/io/sentry/spring/tracing/SentryTracingFilterTest.kt # sentry-spring/src/test/kotlin/io/sentry/spring/tracing/SentryTransactionAdviceTest.kt # sentry/api/sentry.api # sentry/src/main/java/io/sentry/Hub.java # sentry/src/main/java/io/sentry/HubAdapter.java # sentry/src/main/java/io/sentry/IHub.java # sentry/src/main/java/io/sentry/ISentryClient.java # sentry/src/main/java/io/sentry/NoOpHub.java # sentry/src/main/java/io/sentry/NoOpSentryClient.java # sentry/src/main/java/io/sentry/SentryClient.java # sentry/src/test/java/io/sentry/HubTest.kt # sentry/src/test/java/io/sentry/SentryClientTest.kt # sentry/src/test/java/io/sentry/SentryOptionsTest.kt # sentry/src/test/java/io/sentry/SentryTracerTest.kt
added ser/deser logic to ProfilingTraceData (+ tests) several updates for v6
codecov-commenter
commented
Apr 1, 2022
Codecov Report
@@ Coverage Diff @@## 6.x.x #1973 +/- ##
============================================
+ Coverage 75.46% 80.57% +5.11% - Complexity 2248 3024 +776
============================================
Files 225 217 -8 Lines 8036 11215 +3179 Branches 851 1498 +647 ============================================
+ Hits 6064 9036 +2972 - Misses 1562 1620 +58 - Partials 410 559 +149
Continue to review full report at Codecov.
|
stefanosiano
commented
Apr 1, 2022
ContributorAuthor
Review not required to merge... 🤔 😈 |
marandaneto
commented
Apr 4, 2022
Contributor
@stefanosiano can you point us to which commits actually implement the serialization/deserialization of the new protocol? otherwise, it's hard to review. |
marandaneto
commented
Apr 4, 2022
Contributor
Such rules exist only in |
stefanosiano
commented
Apr 4, 2022
ContributorAuthor
@marandaneto Sure, the json commit is c860b8c |
stefanosiano
commented
Apr 5, 2022
ContributorAuthor
@marandaneto Can i merge it or should i wait for your review? |
marandaneto
commented
Apr 5, 2022
Contributor
@romtsn would you like to take this one? |
romtsn
commented
Apr 5, 2022
Member
@marandaneto will do! |
romtsn
approved these changes
Apr 5, 2022
romtsn
left a comment
Member
There was a problem hiding this comment.
Few minor comments, but lgtm otherwise!
| @@ -0,0 +1,16 @@ | |||
| package io.sentry | |||
Member
There was a problem hiding this comment.
I feel like this file (and FileUtilsTest) are in the wrong folder (see Sentry with capital "S"). I think we shouldn't have this Sentry folder in the first place ;)
ContributorAuthor
There was a problem hiding this comment.
This is weird... there's no Sentry folder anywhere... maybe due to mac being case insensitive.
However, I fixed it with command line :/
| * Feat: Add Android profiling traces #1897 and its tests #1949 | ||
| - All operations involving file reads for profiling were moved to the background #1959 | ||
| ## 5.6.2 |
Member
There was a problem hiding this comment.
I think you need to rebase/merge on 6.x.x again, this change should not be here (i.e. only the profiling changelog is relevant)
| @@ -0,0 +1 @@ | |||
| 25b45607-d437-496f-9610-fb43a692dd7c No newline at end of file | |||
Member
There was a problem hiding this comment.
This also should be gone from the PR I believe
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add profiling feature to Sentry v6
#skip-changelog