Skip to content

Add beforeSendTransaction which allows users to filter and change transactions - #2388

Merged
adinauer merged 3 commits into
mainfrom
feat/add-before-send-transaction
Nov 28, 2022
Merged

Add beforeSendTransaction which allows users to filter and change transactions#2388
adinauer merged 3 commits into
mainfrom
feat/add-before-send-transaction

Conversation

@adinauer

Copy link
Copy Markdown
Member

📜 Description

Similar to beforeSend for errors beforeSendTransaction allows users to change and filter transactions.

💡 Motivation and Context

Closes#2358

💚 How did you test it?

Unit tests, ran sample

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions

github-actionsBot commented Nov 24, 2022

Copy link
Copy Markdown
Contributor
Messages
📖Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c83f2ba

@github-actions

github-actionsBot commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time373.33 ms470.04 ms96.71 ms
Size1.73 MiB2.32 MiB612.15 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
507f924342.51 ms402.65 ms60.14 ms
b85d8aa289.35 ms335.92 ms46.56 ms
4a9c176320.62 ms334.68 ms14.06 ms
7597ded289.60 ms339.69 ms50.09 ms
3695453299.25 ms360.04 ms60.79 ms
f809aac301.51 ms346.60 ms45.09 ms
3695453314.63 ms353.10 ms38.47 ms
3695453301.78 ms371.14 ms69.36 ms
4a9c176319.77 ms363.20 ms43.43 ms
90e9745314.68 ms357.28 ms42.60 ms

App size

RevisionPlainWith SentryDiff
507f9241.73 MiB2.32 MiB609.95 KiB
b85d8aa1.73 MiB2.32 MiB611.62 KiB
4a9c1761.73 MiB2.33 MiB612.69 KiB
7597ded1.73 MiB2.32 MiB609.88 KiB
36954531.73 MiB2.32 MiB611.62 KiB
f809aac1.73 MiB2.32 MiB608.63 KiB
36954531.73 MiB2.32 MiB611.62 KiB
36954531.73 MiB2.32 MiB611.62 KiB
4a9c1761.73 MiB2.33 MiB612.69 KiB
90e97451.73 MiB2.32 MiB608.63 KiB

Previous results on branch: feat/add-before-send-transaction

Startup times

RevisionPlainWith SentryDiff
92bac29342.22 ms380.43 ms38.20 ms
96f3228315.83 ms360.46 ms44.63 ms

App size

RevisionPlainWith SentryDiff
92bac291.73 MiB2.32 MiB612.15 KiB
96f32281.73 MiB2.32 MiB612.15 KiB

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 80.24% // Head: 80.28% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (e5f2f86) compared to base (3695453).
Patch coverage: 97.29% of modified lines in pull request are covered.

❗ Current head e5f2f86 differs from pull request most recent head c4c253e. Consider uploading reports for the commit c4c253e to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #2388 +/- ##
============================================
+ Coverage 80.24% 80.28% +0.04% - Complexity 3690 3695 +5 
============================================
Files 292 292 Lines 13853 13890 +37 Branches 1836 1839 +3 ============================================
+ Hits 11116 11152 +36 
Misses 2021 2021 - Partials 716 717 +1 
Impacted FilesCoverage Δ
sentry/src/main/java/io/sentry/SentryClient.java86.02% <96.15%> (+0.67%)⬆️
...y/spring/boot/jakarta/SentryAutoConfiguration.java98.46% <100.00%> (+0.02%)⬆️
...io/sentry/spring/boot/SentryAutoConfiguration.java98.46% <100.00%> (+0.02%)⬆️
...ry/spring/jakarta/SentryInitBeanPostProcessor.java97.56% <100.00%> (+0.19%)⬆️
.../io/sentry/spring/SentryInitBeanPostProcessor.java97.56% <100.00%> (+0.19%)⬆️
sentry/src/main/java/io/sentry/SentryOptions.java81.21% <100.00%> (+0.13%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsnromtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@adinauer
adinauer merged commit b39d6a0 into mainNov 28, 2022
@adinauer
adinauer deleted the feat/add-before-send-transaction branch November 28, 2022 11:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add beforeSendTransaction

3 participants

@adinauer@codecov-commenter@romtsn