Skip to content

Adapt span op and description for graphql - #2607

Merged
adinauer merged 4 commits into
mainfrom
feat/align_span_op_spec
Mar 16, 2023
Merged

Adapt span op and description for graphql#2607
adinauer merged 4 commits into
mainfrom
feat/align_span_op_spec

Conversation

@lbloder

@lbloderlbloder commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

📜 Description

Adapt Span op and description for graphql integrations to fit spec

💡 Motivation and Context

Fixes#2261

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actionsBot commented Mar 15, 2023

Copy link
Copy Markdown
Contributor
Messages
📖Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0cfb7e0

@github-actions

github-actionsBot commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time291.33 ms374.04 ms82.71 ms
Size1.73 MiB2.34 MiB626.08 KiB

Previous results on branch: feat/align_span_op_spec

Startup times

RevisionPlainWith SentryDiff
688afc2339.17 ms366.08 ms26.91 ms
68e2003321.00 ms380.06 ms59.06 ms

App size

RevisionPlainWith SentryDiff
688afc21.73 MiB2.34 MiB626.68 KiB
68e20031.73 MiB2.34 MiB626.08 KiB

@codecov

codecovBot commented Mar 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (5bebc56) 81.30% compared to head (0cfb7e0) 81.31%.

Additional details and impacted files
@@ Coverage Diff @@## main #2607 +/- ##
=========================================
Coverage 81.30% 81.31% - Complexity 4186 4187 +1 
=========================================
Files 336 336 Lines 15484 15486 +2 Branches 2022 2021 -1 =========================================
+ Hits 12589 12592 +3 
Misses 2101 2101 + Partials 794 793 -1 
Impacted FilesCoverage Δ
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt81.91% <66.66%> (+1.06%)⬆️
...n/java/io/sentry/apollo/SentryApolloInterceptor.kt82.35% <100.00%> (+0.21%)⬆️
.../java/io/sentry/graphql/SentryInstrumentation.java73.01% <100.00%> (+0.43%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbloder
lbloder marked this pull request as ready for review March 16, 2023 08:58

@adinaueradinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@adinauer
adinauer merged commit 910071f into mainMar 16, 2023
@adinauer
adinauer deleted the feat/align_span_op_spec branch March 16, 2023 10:39
romtsn pushed a commit that referenced this pull request Mar 16, 2023
Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align span op spec

2 participants

@lbloder@adinauer