Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add GraphQL Apollo Kotlin 4 integration - #4166

Merged
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4
Feb 24, 2025
Merged

Add GraphQL Apollo Kotlin 4 integration#4166
lcian merged 12 commits into
mainfrom
lcian/feat/apollo-4

Conversation

@lcian

@lcianlcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

Adds a new module to integrate Apollo Kotlin 4.

💡 Motivation and Context

Closes#3662

💚 How did you test it?

Unit tests with both ApolloCall<D>::execute and ApolloCall<D>::executeV3 (behaving as v3).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@lcian

lcian commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: https://github.com/getsentry/sentry-java/pull/4166/files/4fac45da4ca55a72121135b0b641c209da0a4661..59977875b26d512fa23f365827ec5f1b8077e367

@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

PlainWith SentryDiff
Startup time392.31 ms455.23 ms62.92 ms
Size1.58 MiB2.21 MiB641.48 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
c2c78de415.28 ms505.08 ms89.80 ms

App size

RevisionPlainWith SentryDiff
c2c78de1.58 MiB2.21 MiB640.27 KiB

Previous results on branch: lcian/feat/apollo-4

Startup times

RevisionPlainWith SentryDiff
b6f49c8347.02 ms419.10 ms72.08 ms
afa0712379.70 ms463.00 ms83.30 ms
98d90f9410.86 ms515.15 ms104.29 ms

App size

RevisionPlainWith SentryDiff
b6f49c81.58 MiB2.21 MiB641.11 KiB
afa07121.58 MiB2.21 MiB641.06 KiB
98d90f91.58 MiB2.21 MiB641.09 KiB

lcian
lcian commented Feb 14, 2025
View reviewed changes
Comment threadsentry-compose/build.gradle.kts
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/generated/type/GraphQLBoolean.kt
Comment thread...pollo-4/src/test/java/io/sentry/apollo4/generated/selections/LaunchDetailsQuerySelections.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4.kt
Comment threadsentry-apollo-4/src/main/java/io/sentry/apollo4/SentryApollo4ClientException.kt
Comment thread...y-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4BuilderExtensionsClientErrorsTest.kt
Comment threadsentry-apollo-4/src/test/java/io/sentry/apollo4/SentryApollo4HttpInterceptorTest.kt
@lcian
lcian marked this pull request as ready for review February 14, 2025 12:42
@lcianlcian mentioned this pull request Feb 14, 2025
Merged
3 tasks
@lcian
lcian requested a review from lbloderFebruary 17, 2025 11:31
markushi
markushi approved these changes Feb 19, 2025
View reviewed changes

@markushimarkushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: to review this I would recommend just looking at the diff between the first commit in the PR and the last one, the first commit is porting the code we have for v3 to v4
i.e. use this to review: 4fac45da..59977875 (#4166)

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

@lcian

lcian commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

I mainly reviewed exactly that, looks good to me! Do you think we should release this in an alpha version first?

Thanks @markushi !
I've tested this manually too and I don't see any way this could break customer's code, so I think we could release it in a regular version. Please let me know if you think otherwise.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Since this adds a new module and doesn't change existing code I think it's safe to release without an alpha as the only customers affected are those explicitly using the new Apollo 4 dependency and actively configuring it to be used.

@adinauer

adinauer commented Feb 20, 2025

Copy link
Copy Markdown
Member

Deferring to @lbloder for a review here since he wrote the integration for v3.

lbloder
lbloder approved these changes Feb 24, 2025
View reviewed changes

@lbloderlbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done 👍

To make the CI run successfully, you'll need to run make api once locally and push the changes.

@lcianlcian changed the title Add Apollo 4 integrationAdd GraphQL Apollo Kotlin 4 integrationFeb 24, 2025
@lcian

lcian commented Feb 24, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for kickstarting this @cvb941 !

@lcian
lcian merged commit c87d429 into mainFeb 24, 2025
@lcian
lcian deleted the lcian/feat/apollo-4 branch February 24, 2025 12:35
@lcianlcian mentioned this pull request Feb 24, 2025
Closed
6 tasks
@cvb941

cvb941 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

thanks @lcian for the work here, I hope many people will use the updated Apollo integration as well 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushimarkushimarkushi approved these changes
@lbloderlbloderlbloder approved these changes
@adinaueradinauerAwaiting requested review from adinaueradinauer is a code owner
@romtsnromtsnAwaiting requested review from romtsnromtsn is a code owner
@stefanosianostefanosianoAwaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Apollo4

5 participants

@lcian@adinauer@cvb941@markushi@lbloder