Uh oh!
There was an error while loading. Please reload this page.
Revert "feat!: Remove support for Node < v18 and webpack v4" - #887
Revert "feat!: Remove support for Node < v18 and webpack v4"#887andreiborza wants to merge 1 commit into
Conversation
This reverts commit e924c12.
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| }/webpack4`, | ||
| }, | ||
| }), | ||
| ], | ||
| }, | ||
| (err) => { | ||
| if (err) { | ||
| throw err; | ||
| } | ||
| } | ||
| ); |
There was a problem hiding this comment.
Bug: The e2e test utility create-cjs-bundles.ts unconditionally runs webpack4, which will fail on Node.js 18+ when the currently disabled e2e tests are re-enabled.
Severity: MEDIUM
Suggested Fix
Add a Node.js version check in packages/e2e-tests/utils/create-cjs-bundles.ts to skip the webpack4 build process when the major version is 18 or greater. This will align its behavior with similar scripts like create-cjs-bundles-for-react.ts.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/e2e-tests/utils/create-cjs-bundles.ts#L91-L122
Potential issue: The script at `packages/e2e-tests/utils/create-cjs-bundles.ts`
unconditionally executes a webpack4 build. This is problematic because webpack4 is
incompatible with Node.js versions 18 and higher, causing build failures. While the e2e
tests are currently disabled in the CI pipeline, this latent bug will manifest as soon
as they are re-enabled in an environment running a modern Node.js version. Other similar
utility scripts in the integration tests already contain guards to prevent this exact
issue by checking the Node.js version before attempting to run webpack4.
Did we get this right? 👍 / 👎 to inform future reviews.
andreiborza
commented
Feb 23, 2026
Will just cherry-pick #875 onto a v4 branch... |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| export const testIfNodeMajorVersionIsLessThan18: jest.It = function () { | ||
| return testIf(NODE_MAJOR_VERSION < 18); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| } as any; |
There was a problem hiding this comment.
Webpack 4 tests silently never register or execute
High Severity
testIfNodeMajorVersionIsLessThan18 is defined as a wrapper function that calls testIf() and returns the result (test or test.skip), but it ignores the arguments passed to it (test name and callback). When invoked as testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => { ... }), the test name and callback are never forwarded to test/test.skip, so the test is silently never registered. Compare with describeNode18Plus, which correctly assigns the result of the condition directly. The fix is to evaluate testIf(NODE_MAJOR_VERSION < 18) eagerly and assign its result, rather than wrapping it in another function layer.
Reverts #886
We want to ship a v4 release first before getting this out