After v8 gets merged in, let's look at migrating from jest to vitest. vitest is way faster, and doesn't fall into the same traps jest does in terms of esm compatibility. Example attempt with Vue SDK: #11071
In addition, we should stop using jsdom based tests, and instead move tests that rely on the browser to use playwright instead. Simulating jsdom in an node environment always has it's faults, easier to not attempt to do that.
First we should align on a common vitest testing standard. Right now we use set globals via vitest/globals, but this is not recommended by vitest themselves. We should instead use direct imports like import { describe, test, expect } from 'vitest';.
| "types": ["node", "jest", "vitest/globals"] |
There's probably some other discussion that needs to be done here too. We can validate our decisions by changing our vitest usage in the Astro and SvelteKit SDKs.
### Update existing vitest usage
- [ ] https://github.com/getsentry/sentry-javascript/pull/13093
- [ ] https://github.com/getsentry/sentry-javascript/pull/13214
- [ ] Nuxt SDK
- [ ] https://github.com/getsentry/sentry-javascript/pull/13028
- [ ] SolidStart SDK
- [ ] https://github.com/getsentry/sentry-javascript/pull/13026
- [ ] https://github.com/getsentry/sentry-javascript/pull/12960
- [ ] https://github.com/getsentry/sentry-javascript/pull/13027
We can then tackle the following list in whatever order we want!
### Convert to using vitest
- [x] Angular https://github.com/getsentry/sentry-javascript/pull/11091
- [ ] https://github.com/getsentry/sentry-javascript/pull/13092
- [ ] https://github.com/getsentry/sentry-javascript/issues/13434
- [x] Browser Utils
- [ ] https://github.com/getsentry/sentry-javascript/pull/15497
- [ ] https://github.com/getsentry/sentry-javascript/pull/15494
- [ ] https://github.com/getsentry/sentry-javascript/issues/13605
- [ ] https://github.com/getsentry/sentry-javascript/pull/15492
- [ ] https://github.com/getsentry/sentry-javascript/pull/12964
- [ ] https://github.com/getsentry/sentry-javascript/pull/11899
- [ ] https://github.com/getsentry/sentry-javascript/pull/12961
- [ ] https://github.com/getsentry/sentry-javascript/pull/12958
- [ ] https://github.com/getsentry/sentry-javascript/pull/12955
- [x] Wasm
- [ ] https://github.com/getsentry/sentry-javascript/pull/15499
- [ ] https://github.com/getsentry/sentry-javascript/pull/15546
We also have some packages that use mocha. We should try to drop that dependency and make them use vitest
### Remove mocha
- [ ] https://github.com/getsentry/sentry-javascript/pull/11296
- [ ] https://github.com/getsentry/sentry-javascript/pull/11412
- [ ] https://github.com/getsentry/sentry-javascript/pull/11436
- [ ] https://github.com/getsentry/sentry-javascript/pull/11449
- [ ] https://github.com/getsentry/sentry-javascript/pull/11666
- [ ] https://github.com/getsentry/sentry-javascript/pull/11688
- [ ] https://github.com/getsentry/sentry-javascript/pull/11733
- [ ] https://github.com/getsentry/sentry-javascript/pull/11758
After v8 gets merged in, let's look at migrating from jest to vitest.
vitestis way faster, and doesn't fall into the same trapsjestdoes in terms of esm compatibility. Example attempt with Vue SDK: #11071In addition, we should stop using jsdom based tests, and instead move tests that rely on the browser to use playwright instead. Simulating jsdom in an node environment always has it's faults, easier to not attempt to do that.
First we should align on a common vitest testing standard. Right now we use set globals via
vitest/globals, but this is not recommended byvitestthemselves. We should instead use direct imports likeimport { describe, test, expect } from 'vitest';.sentry-javascript/tsconfig.dev.json
Line 8 in 780875f
There's probably some other discussion that needs to be done here too. We can validate our decisions by changing our vitest usage in the Astro and SvelteKit SDKs.
We can then tackle the following list in whatever order we want!
We also have some packages that use
mocha. We should try to drop that dependency and make them usevitest