Sveltekit plugin unexpected adapter detection causes sourcemaps to not be built

[ksmoore17]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/sveltekit

SDK Version

10.38.0

Framework Version

Sveltekit 2.50.2

Link to Sentry event

No response

Reproduction Example/SDK Setup

import adapterCloudflare from '@sveltejs/adapter-cloudflare';
import adapterNode from '@sveltejs/adapter-node';
import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';


/** @type {import('@sveltejs/kit').Config} */
const config = {
	preprocess: vitePreprocess(),

	kit: {
		adapter: process.env.ADAPTER === 'node' ? adapterNode() : adapterCloudflare(),
		experimental: {
			remoteFunctions: true,
			tracing: { server: true },
			instrumentation: { server: true }
		}
	}
};

export default config;

import { sveltekit } from '@sveltejs/kit/vite';
import { sentrySvelteKit } from '@sentry/sveltekit';

export default defineConfig(({ mode }) => {
	return {
		plugins: [
			sentrySvelteKit({
				org: '<org>',
				project: '<project>',
				authToken: process.env.SENTRY_AUTH_TOKEN
			}),
			sveltekit(),
		]
	};
});

Steps to Reproduce

1. Sveltekit app with the given configuration (dynamically choosing between two adapters)
2. Deploy on cloudflare with necessary token in env vars (but without ADAPTER='node')
3. Sourcemaps fail to upload

Expected Result

Successful auto upload of sourcemaps when auth token is provided

cloudflare build logs:
[sentry-vite-plugin] Info: Successfully uploaded source maps to Sentry

Actual Result

Vite builds using cloudflare adapter but sentry vite plugin detects node adapter and fails to find the sources.

cloudflare build logs:
[sentry-vite-plugin] Warning: Didn't find any matching sources for debug ID upload. Please check the `sourcemaps.assets` option.

Additional Context

The simple solution was to add the adapter: 'cloudflare' to the sentrySvelteKit plugin options, But I was thrown off because I have other sites that use the same plugin config (without that option provided) that were detecting the cloudflare adapter and uploading the sourcemaps. I use the node adapter to run a test instance, and the cloudflare adapter for the production deployment.

I can see that the detectAdapter code looks in the dependencies and picks the node adapter (with priority) in my situation. I can also see that I would have caught this if I had turned on the plugin debug option 😅.

The docs mention this option and what to do if "the wrong one was detected", but it wasn't clear from the build logs that the node adapter was being used. Might I suggest that the docs explain that the plugin detects adapter from dependencies?

Some other ways to prevent this problem for others would be to show the adapter detection log outside of debug mode or to detect the adapter the same way as sveltekit's adapter-auto as a default rather than reading the dependencies.

Thank you

Priority

_{React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.}

[linear]

JS-1642

[Lms24]

Hey @ksmoore17 thanks for reporting! Gotta admit, I didn't think the conditional adapter selection through 😅

I wanna explore some angles here how to most robustly fix this. Some thoughts:

• maybe we can get rid of detecting adapters to set the directory for source maps and just set a global ./**/*.map glob internally. You can always override the source maps dir manually via the sourcemaps.assets option in the sentrySvelteKit plugin options. This should fix the problem at its root.
• The adapter-auto detection logic sounds like a solid improvement. However, we'll still need to fall back to package.json lookup though, in case the app is built locally or in CI rather than directly on the platform.
• I think we can improve the docs a bit but I'd rather avoid logging outside of debug mode simply due to having received too many complaints how noisy Sentry is when building already 😅

[Lms24]

Update: I opened #19270 with a fix that IMHO should cover this case (and probably a lot of other similar ones). Feel free to take a look!