Review redis diagnostics_channel span attribute names

[isaacs]

For each, evaluate if it is:

• following the conventions (no need to change)
• ought to be changed to follow the conventions, or
• ought to be a new proposed convention

[linear-code]

JS-2636