test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(node): New Node integration test runner - #10117

Merged
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner
Jan 11, 2024
Merged

test(node): New Node integration test runner#10117
AbhiPrasad merged 27 commits into
getsentry:developfrom
timfish:test/e2e-runner

Conversation

@timfish

@timfishtimfish commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

To aid in adding tests for #9907

Adds a new Node integration test runner that runs the scenario in its own Node process and reads the envelope back from stdout.

I have converted all the Anr and LocalVariables tests to use this new format.

How to use

First, in your test scenario, you need to set the transport to the loggingTransport from @sentry-internal/node-integration-tests. This will cause envelopes to be logged to stdout as a single line of JSON:

import*asSentryfrom'@sentry/node';import{loggingTransport}from'@sentry-internal/node-integration-tests';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',transport: loggingTransport,});

Then in your test, use the createRunner function to create your test. The createRunner args are the path segments to the scenario. If you pass a typescript entry file, -r ts-node/register gets added to the node args.

Every expect call adds an expected envelope item. Currently you can expect event, transaction and session but it's easy to add extra type-safe expectations. You must add an expect for every envelope item that will be sent and they must be in the correct order or an error is thrown and the test fails. The expect event/transaction/session can be a callback or an object that will be tested against the received envelope.

If you don't care about specific types of envelope item, you can ignore them:

createRunner(__dirname,'basic.js').ignore('session','sessions').expect(//...

If you pass done to start, done will be called when all the envelope items have matched the expected and done will be passed any errors that occur which ends the test without waiting for the timeout.

Example

Here is an Anr test that ensures we get the expected session envelope followed by the expected event envelope:

import{assertSentryEvent,assertSentrySession,createRunner}from'../../utils/runner';constEXPECTED_ANR_EVENT={// Ensure we have contextcontexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),},device: {arch: expect.any(String),},app: {app_start_time: expect.any(String),},os: {name: expect.any(String),},culture: {timezone: expect.any(String),},},// and an exception that is our ANRexception: {values: [{type: 'ApplicationNotResponding',value: 'Application Not Responding for at least 200 ms',mechanism: {type: 'ANR'},stacktrace: {frames: expect.arrayContaining([{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: '?',in_app: true,},{colno: expect.any(Number),lineno: expect.any(Number),filename: expect.any(String),function: 'longWork',in_app: true,},]),},},],},};test('Anr with session',done=>{createRunner(__dirname,'basic-session.js').expect({session: {status: 'abnormal',abnormal_mechanism: 'anr_foreground'}}).expect({event: EXPECTED_ANR_EVENT}).start(done);});

It's also possible to pass flags to node via the withFlags() function:

test('With --inspect',done=>{createRunner(__dirname,'basic.mjs').withFlags('--inspect').expect({event: EXPECTED_ANR_EVENT}).start(done);});

@timfishtimfish changed the title test(node): New ee2e test runnertest(node): New Node e2e test runnerJan 9, 2024
@mydea

mydea commented Jan 9, 2024

Copy link
Copy Markdown
Member

this sounds nice! Does that work with OpenTelemetry, I wonder? So with node-experimental? Would be a great way to write tests for integrations etc...!

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that work with OpenTelemetry, I wonder? So with node-experimental?

Yep, that's partly what its for:

test('otel with loader',done=>{createRunner(__dirname,'express-otel.mjs').withFlags('--experimental-loader=@opentelemetry/instrumentation/hook.mjs').expect({transaction: EXPRESS_TRANSACTION}).start(done);});

@timfish

timfish commented Jan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I've added server request support and modified some of the express tracing tests to use the new runner.

To support server requests, make the following changes to your test scenario:

image

It can then be tested by calling makeRequest:

test('should create and send transactions for Express routes and spans for middlewares.',done=>{createRunner(__dirname,'server.ts').expect({transaction: {contexts: {trace: {span_id: expect.any(String),trace_id: expect.any(String),data: {url: '/test/express','http.response.status_code': 200,},op: 'http.server',status: 'ok',tags: {'http.status_code': '200',},},},spans: [expect.objectContaining({description: 'corsMiddleware',op: 'middleware.express.use',}),],},}).start(done).makeRequest('get','/test/express');});

"type-check": "tsc",
"pretest": "run-s --silent prisma:init prisma:init:new",
"test": "ts-node ./utils/run-tests.ts",
"jest": "jest --config ./jest.config.js",

@timfishtimfishJan 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this simply because it allows you to call yarn jest -t "name-of-test" --verbose and get debug output very quickly from a single test. yarn test -t "name-of-test" runs through the existing custom test runner code and takes ages...

Hopefully we can migrate to just using the jest runner!

@timfish
timfish marked this pull request as ready for review January 10, 2024 10:40
@lforstlforst changed the title test(node): New Node e2e test runnertest(node): New Node integration test runnerJan 10, 2024
@lforst
lforst self-requested a review January 11, 2024 11:29

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad
AbhiPrasad merged commit 98979d8 into getsentry:developJan 11, 2024
@timfish
timfish deleted the test/e2e-runner branch January 23, 2024 14:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@mydea@lforst@AbhiPrasad