Uh oh!
There was an error while loading. Please reload this page.
feat(core): Deprecate methods on Hub - #10124
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
fn/deprecate-hubMethods
branch
from
January 10, 2024 09:13
59d1061 to
661cd22Comparelforst
approved these changes
Jan 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mydeaforce-pushed
the
fn/deprecate-hubMethods
branch
from
January 10, 2024 11:09
661cd22 to
039bad6CompareExcept for `bindClient()` which needs a separate replacement. For everything else we already have a replacement in place!
mydeaforce-pushed
the
fn/deprecate-hubMethods
branch
from
January 10, 2024 12:33
039bad6 to
983624eCompareLms24
approved these changes
Jan 10, 2024
c298lee pushed a commit
that referenced
this pull request
Jan 10, 2024
c298lee pushed a commit
that referenced
this pull request
Jan 10, 2024
billyvg pushed a commit
that referenced
this pull request
Jan 10, 2024
c298lee pushed a commit
that referenced
this pull request
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Except for
bindClient()which needs a separate replacement. For everything else we already have a replacement in place!Then in a follow up we can deprecate
getCurrentHub()itself.