test(node): Add `mysql` auto instrumentation tests for `@sentry/node-experimental` by timfish · Pull Request #10255 · getsentry/sentry-javascript

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

timfish · 2024-01-18T17:36:41Z

This PR adds auto instrumentation tests for mysql for @sentry/node-experimental.

There are no ESM tests because mysql does not support ESM!

…perimental`

+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


+const mysql = require('mysql');
+
+const connection = mysql.createConnection({
+ user: 'root',


+
+const connection = mysql.createConnection({
+ user: 'root',
+ password: 'docker',


mydea · 2024-01-19T08:22:56Z

There are no ESM tests because mysql does not support ESM!

We should try to contribute upstream to make this work 😬 Do you have any clue why it doesn't work with ESM? Maybe it is similar to what I had to do for fastify to make it work with ESM: open-telemetry/opentelemetry-js-contrib#1624

test(node): Add Mysql auto instrumentation tests for `@sentry/node-ex…
691d222
…perimental`

timfish changed the title ~~test(node): Add 'mysql auto instrumentation tests for @sentry/node-experimental`~~test(node): Add mysql auto instrumentation tests for @sentry/node-experimentalJan 18, 2024

github-advanced-securityAI found potential problems Jan 18, 2024
View reviewed changes

combine the tests and only run on node 14+
579acaf

github-advanced-securityAI found potential problems Jan 18, 2024
View reviewed changes

timfish marked this pull request as ready for review January 18, 2024 18:39

AbhiPrasad approved these changes Jan 18, 2024
View reviewed changes

AbhiPrasad merged commit a380b93 into getsentry:developJan 18, 2024

timfish deleted the test/otel-mysql branch January 18, 2024 19:38