Skip to content

feat(core): Add metric summaries to spans - #10554

Merged
AbhiPrasad merged 12 commits into
developfrom
metrics-summary
Feb 12, 2024
Merged

feat(core): Add metric summaries to spans#10554
AbhiPrasad merged 12 commits into
developfrom
metrics-summary

Conversation

@cleptric

@cleptriccleptric commented Feb 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member
image

@cleptriccleptric self-assigned this Feb 7, 2024
@github-actions

github-actionsBot commented Feb 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)77.95 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)69.18 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)73.11 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)62.79 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)33.37 KB (+0.3% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)33.23 KB (+0.31% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.16 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.16 KB (+0.08% 🔺)
@sentry/browser - Webpack (gzipped)22.43 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)76.09 KB (+0.38% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.6 KB (+0.35% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)33.59 KB (+0.77% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped)24.64 KB (+0.86% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)212.93 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)101.55 KB (+0.59% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)73.83 KB (+0.61% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)36.83 KB (+0.75% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)69.55 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped)22.46 KB (+0.09% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.34 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped)50.45 KB (+0.14% 🔺)
@sentry-internal/feedback - Webpack (gzipped)17.1 KB (+0.01% 🔺)

@cleptric
cleptric marked this pull request as ready for review February 8, 2024 13:50
@cleptric
cleptric requested review from a team, AbhiPrasad and stephanie-anderson and removed request for a team, AbhiPrasad and stephanie-andersonFebruary 8, 2024 13:50
AbhiPrasad
AbhiPrasad reviewed Feb 8, 2024
View reviewed changes
Comment threadpackages/core/src/metrics/metric-summary.ts Outdated
@AbhiPrasadAbhiPrasad changed the title Metrics summaryfeat(core): Add metric summaries to spansFeb 8, 2024
@AbhiPrasad

AbhiPrasad commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

@cleptric there's some formatting issues, mind running yarn fix and pushing?

@AbhiPrasad

AbhiPrasad commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

I ended up pushing yarn fix to 1b32bc5

Going to merge it in now!

@AbhiPrasad
AbhiPrasad merged commit 860dd2f into developFeb 12, 2024
@AbhiPrasad
AbhiPrasad deleted the metrics-summary branch February 12, 2024 15:16
AbhiPrasad added a commit that referenced this pull request Feb 12, 2024
@cleptric@AbhiPrasad
feat(core): Add metric summaries to spans (#10554)
7b3a22d
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@AbhiPrasadAbhiPrasad mentioned this pull request Feb 12, 2024
Merged
This was referenced Feb 14, 2024
Merged
Closed
Merged
@timfishtimfish mentioned this pull request Feb 25, 2024
Closed
This was referenced Mar 12, 2024
Merged
Closed
@Lms24Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24Lms24 mentioned this pull request Apr 10, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
@Lms24Lms24 mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timfishtimfishAwaiting requested review from timfish
1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cleptriccleptric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cleptric@AbhiPrasad