ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 1 commit into from
Feb 9, 2024
Merged

ref: Remove lastEventId#10585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/astro/src/index.server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
5 changes: 0 additions & 5 deletions packages/astro/src/index.types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export declare function lastEventId(): string | undefined;

export default sentryAstro;
2 changes: 0 additions & 2 deletions packages/browser/src/exports.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
getCurrentScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
Expand Down
7 changes: 0 additions & 7 deletions packages/browser/src/sdk.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
};
}

// TODO(v8): Remove this entire if statement. `eventId` will be a required option.
// eslint-disable-next-line deprecation/deprecation
if (!options.eventId) {
// eslint-disable-next-line deprecation/deprecation
options.eventId = hub.lastEventId();
}

const script = WINDOW.document.createElement('script');
script.async = true;
script.crossOrigin = 'anonymous';
Expand Down
2 changes: 0 additions & 2 deletions packages/bun/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
11 changes: 0 additions & 11 deletions packages/core/src/exports.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
return Promise.resolve(false);
}

/**
* This is the getter for lastEventId.
*
* @returns The last event id of a captured event.
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export function lastEventId(): string | undefined {
// eslint-disable-next-line deprecation/deprecation
return getCurrentHub().lastEventId();
}

/**
* Get the currently active client.
*/
Expand Down
19 changes: 2 additions & 17 deletions packages/core/src/hub.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
/** Is a {@link Layer}[] containing the client and scope */
private readonly _stack: Layer[];

/** Contains the last event id of a captured event. */
private _lastEventId?: string;

private _isolationScope: Scope;

/**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
* @deprecated Use `Sentry.captureException()` instead.
*/
public captureException(exception: unknown, hint?: EventHint): string {
const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
const syntheticException = new Error('Sentry syntheticException');
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
* @deprecated Use `Sentry.captureMessage()` instead.
*/
public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
const syntheticException = new Error(message);
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
*/
public captureEvent(event: Event, hint?: EventHint): string {
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
if (!event.type) {
this._lastEventId = eventId;
}
// eslint-disable-next-line deprecation/deprecation
this.getScope().captureEvent(event, { ...hint, event_id: eventId });
return eventId;
}

/**
* @inheritDoc
*
* @deprecated This will be removed in v8.
*/
public lastEventId(): string | undefined {
return this._lastEventId;
}

/**
* @inheritDoc
*
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
configureScope,
flush,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
startTransaction,
setContext,
setExtra,
Expand Down
2 changes: 0 additions & 2 deletions packages/deno/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
captureMessage,
addGlobalEventProcessor,
addEventProcessor,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
setContext,
setExtra,
setExtras,
Expand Down
9 changes: 0 additions & 9 deletions packages/node-experimental/src/sdk/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
});
}

/**
* Get the ID of the last sent error event.
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export function lastEventId(): string | undefined {
// eslint-disable-next-line deprecation/deprecation
return getCurrentScope().lastEventId();
}

/**
* Configure the current scope.
* @deprecated Use `getCurrentScope()` instead.
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/sdk/hub.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
configureScope,
getClient,
getCurrentScope,
lastEventId,
setContext,
setExtra,
setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
return getCurrentScope().captureMessage(message, level, hint);
},
captureEvent,
lastEventId,
addBreadcrumb,
setUser,
setTags,
Expand Down
14 changes: 0 additions & 14 deletions packages/node-experimental/src/sdk/scope.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
protected _client: Client | undefined;

protected _lastEventId: string | undefined;

/**
* @inheritDoc
*/
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
this,
);

this._lastEventId = eventId;

return eventId;
}

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
this,
);

this._lastEventId = eventId;

return eventId;
}

/** Capture a message for this scope. */
public captureEvent(event: Event, hint?: EventHint): string {
const eventId = hint && hint.event_id ? hint.event_id : uuid4();
if (!event.type) {
this._lastEventId = eventId;
}

getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

return eventId;
}

/** Get the ID of the last sent error event. */
public lastEventId(): string | undefined {
return this._lastEventId;
}

/**
* @inheritDoc
*/
Expand Down
4 changes: 0 additions & 4 deletions packages/node-experimental/src/sdk/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
// @ts-expect-error typeof this is what we want here
clone(scope?: Scope): typeof this;
/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
lastEventId(): string | undefined;
getScopeData(): ScopeData;
}

Expand Down
2 changes: 0 additions & 2 deletions packages/node/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/errorboundary.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
if (client && client.on && props.showDialog) {
this._openFallbackReportDialog = false;
client.on('afterSendEvent', event => {
if (!event.type && event.event_id === this._lastEventId) {
// eslint-disable-next-line deprecation/deprecation
if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
}
});
Expand Down
2 changes: 0 additions & 2 deletions packages/remix/src/index.server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
6 changes: 0 additions & 6 deletions packages/remix/src/index.types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;
2 changes: 0 additions & 2 deletions packages/serverless/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
flush,
getSentryRelease,
init,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
DEFAULT_USER_INCLUDES,
addRequestDataToEvent,
extractRequestData,
Expand Down
5 changes: 0 additions & 5 deletions packages/sveltekit/src/index.types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
* @deprecated This function will be removed in the next major version of the Sentry SDK.
*/
export declare function lastEventId(): string | undefined;
2 changes: 0 additions & 2 deletions packages/sveltekit/src/server/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
defaultIntegrations,
getDefaultIntegrations,
defaultStackParser,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
flush,
close,
getSentryRelease,
Expand Down
9 changes: 0 additions & 9 deletions packages/types/src/hub.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
*/
captureEvent(event: Event, hint?: EventHint): string;

/**
* This is the getter for lastEventId.
*
* @returns The last event id of a captured event.
*
* @deprecated This will be removed in v8.
*/
lastEventId(): string | undefined;

/**
* Records a new breadcrumb which will be attached to future events.
*
Expand Down
2 changes: 0 additions & 2 deletions packages/vercel-edge/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
getIsolationScope,
Hub,
// eslint-disable-next-line deprecation/deprecation
lastEventId,
// eslint-disable-next-line deprecation/deprecation
makeMain,
setCurrentClient,
runWithAsyncContext,
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ref: Remove lastEventId#10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 1 commit into

from

Feb 9, 2024
 Merged


ref: Remove lastEventId#10585
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 0 additions & 2 deletions
packages/astro/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,8 +58,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

5 changes: 0 additions & 5 deletions
packages/astro/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,9 +26,4 @@ export declare const defaultStackParser: StackParser;
export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

export default sentryAstro;

2 changes: 0 additions & 2 deletions
packages/browser/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,6 @@ export {
 getCurrentScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
Expand Down

7 changes: 0 additions & 7 deletions
packages/browser/src/sdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -198,13 +198,6 @@ export const showReportDialog: ShowReportDialogFunction = (
 };
 }

 // TODO(v8): Remove this entire if statement. `eventId` will be a required option.
 // eslint-disable-next-line deprecation/deprecation
 if (!options.eventId) {
 // eslint-disable-next-line deprecation/deprecation
 options.eventId = hub.lastEventId();
 }

 const script = WINDOW.document.createElement('script');
 script.async = true;
 script.crossOrigin = 'anonymous';
Expand Down

2 changes: 0 additions & 2 deletions
packages/bun/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,8 +49,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

11 changes: 0 additions & 11 deletions
packages/core/src/exports.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -370,17 +370,6 @@ export async function close(timeout?: number): Promise<boolean> {
 return Promise.resolve(false);
}

/**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentHub().lastEventId();
}

/**
 * Get the currently active client.
 */
Expand Down

19 changes: 2 additions & 17 deletions
packages/core/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,9 +121,6 @@ export class Hub implements HubInterface {
 /** Is a {@link Layer}[] containing the client and scope */
 private readonly _stack: Layer[];

 /** Contains the last event id of a captured event. */
 private _lastEventId?: string;

 private _isolationScope: Scope;

 /**
Expand DownExpand Up@@ -354,7 +351,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureException()` instead.
 */
 public captureException(exception: unknown, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error('Sentry syntheticException');
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureException(exception, {
Expand All@@ -373,7 +370,7 @@ export class Hub implements HubInterface {
 * @deprecated Use `Sentry.captureMessage()` instead.
 */
 public captureMessage(message: string, level?: SeverityLevel, hint?: EventHint): string {
 const eventId = (this._lastEventId = hint && hint.event_id ? hint.event_id : uuid4());
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 const syntheticException = new Error(message);
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureMessage(message, level, {
Expand All@@ -393,23 +390,11 @@ export class Hub implements HubInterface {
 */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }
 // eslint-disable-next-line deprecation/deprecation
 this.getScope().captureEvent(event, { ...hint, event_id: eventId });
 return eventId;
 }

 /**
 * @inheritDoc
 *
 * @deprecated This will be removed in v8.
 */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/core/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,8 +20,6 @@ export {
 configureScope,
 flush,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 startTransaction,
 setContext,
 setExtra,
Expand Down

2 changes: 0 additions & 2 deletions
packages/deno/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ export {
 captureMessage,
 addGlobalEventProcessor,
 addEventProcessor,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand Down

9 changes: 0 additions & 9 deletions
packages/node-experimental/src/sdk/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,15 +96,6 @@ export function withIsolationScope<T>(callback: (isolationScope: Scope) => T): T
 });
}

/**
 * Get the ID of the last sent error event.
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export function lastEventId(): string | undefined {
 // eslint-disable-next-line deprecation/deprecation
 return getCurrentScope().lastEventId();
}

/**
 * Configure the current scope.
 * @deprecated Use `getCurrentScope()` instead.
Expand Down

2 changes: 0 additions & 2 deletions
packages/node-experimental/src/sdk/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import {
 configureScope,
 getClient,
 getCurrentScope,
 lastEventId,
 setContext,
 setExtra,
 setExtras,
Expand DownExpand Up@@ -71,7 +70,6 @@ export function getCurrentHub(): Hub {
 return getCurrentScope().captureMessage(message, level, hint);
 },
 captureEvent,
 lastEventId,
 addBreadcrumb,
 setUser,
 setTags,
Expand Down

14 changes: 0 additions & 14 deletions
packages/node-experimental/src/sdk/scope.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -74,8 +74,6 @@ export function isInitialized(): boolean {
export class Scope extends OpenTelemetryScope implements ScopeInterface {
 protected _client: Client | undefined;

 protected _lastEventId: string | undefined;

 /**
 * @inheritDoc
 */
Expand DownExpand Up@@ -131,8 +129,6 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

Expand All@@ -153,28 +149,18 @@ export class Scope extends OpenTelemetryScope implements ScopeInterface {
 this,
 );

 this._lastEventId = eventId;

 return eventId;
 }

 /** Capture a message for this scope. */
 public captureEvent(event: Event, hint?: EventHint): string {
 const eventId = hint && hint.event_id ? hint.event_id : uuid4();
 if (!event.type) {
 this._lastEventId = eventId;
 }

 getClient().captureEvent(event, { ...hint, event_id: eventId }, this);

 return eventId;
 }

 /** Get the ID of the last sent error event. */
 public lastEventId(): string | undefined {
 return this._lastEventId;
 }

 /**
 * @inheritDoc
 */
Expand Down

4 changes: 0 additions & 4 deletions
packages/node-experimental/src/sdk/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,10 +30,6 @@ export interface ScopeData {
export interface Scope extends BaseScope {
 // @ts-expect-error typeof this is what we want here
 clone(scope?: Scope): typeof this;
 /**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
 lastEventId(): string | undefined;
 getScopeData(): ScopeData;
}

Expand Down

2 changes: 0 additions & 2 deletions
packages/node/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down

3 changes: 1 addition & 2 deletions
packages/react/src/errorboundary.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundarySta
 if (client && client.on && props.showDialog) {
 this._openFallbackReportDialog = false;
 client.on('afterSendEvent', event => {
 if (!event.type && event.event_id === this._lastEventId) {
 // eslint-disable-next-line deprecation/deprecation
 if (!event.type && this._lastEventId && event.event_id === this._lastEventId) {
 showReportDialog({ ...props.dialogOptions, eventId: this._lastEventId });
 }
 });
Expand Down

2 changes: 0 additions & 2 deletions
packages/remix/src/index.server.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,8 +62,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

6 changes: 0 additions & 6 deletions
packages/remix/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,9 +29,3 @@ declare const runtime: 'client' | 'server';

export const close = runtime === 'client' ? clientSdk.close : serverSdk.close;
export const flush = runtime === 'client' ? clientSdk.flush : serverSdk.flush;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
// eslint-disable-next-line deprecation/deprecation
export const lastEventId = runtime === 'client' ? clientSdk.lastEventId : serverSdk.lastEventId;

2 changes: 0 additions & 2 deletions
packages/serverless/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,8 +63,6 @@ export {
 flush,
 getSentryRelease,
 init,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 DEFAULT_USER_INCLUDES,
 addRequestDataToEvent,
 extractRequestData,
Expand Down

5 changes: 0 additions & 5 deletions
packages/sveltekit/src/index.types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,3 @@ export declare const defaultStackParser: StackParser;

export declare function close(timeout?: number | undefined): PromiseLike<boolean>;
export declare function flush(timeout?: number | undefined): PromiseLike<boolean>;

/**
 * @deprecated This function will be removed in the next major version of the Sentry SDK.
 */
export declare function lastEventId(): string | undefined;

2 changes: 0 additions & 2 deletions
packages/sveltekit/src/server/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,6 @@ export {
 defaultIntegrations,
 getDefaultIntegrations,
 defaultStackParser,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 flush,
 close,
 getSentryRelease,
Expand Down

9 changes: 0 additions & 9 deletions
packages/types/src/hub.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -128,15 +128,6 @@ export interface Hub {
 */
 captureEvent(event: Event, hint?: EventHint): string;

 /**
 * This is the getter for lastEventId.
 *
 * @returns The last event id of a captured event.
 *
 * @deprecated This will be removed in v8.
 */
 lastEventId(): string | undefined;

 /**
 * Records a new breadcrumb which will be attached to future events.
 *
Expand Down

2 changes: 0 additions & 2 deletions
packages/vercel-edge/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,8 +48,6 @@ export {
 getIsolationScope,
 Hub,
 // eslint-disable-next-line deprecation/deprecation
 lastEventId,
 // eslint-disable-next-line deprecation/deprecation
 makeMain,
 setCurrentClient,
 runWithAsyncContext,
Expand Down