Skip to content

fix(publish): Ensure @sentry/hub is published in v7 - #10661

Merged
Lms24 merged 6 commits into
developfrom
lms/fix-craft-config-hub
Feb 14, 2024
Merged

fix(publish): Ensure @sentry/hub is published in v7#10661
Lms24 merged 6 commits into
developfrom
lms/fix-craft-config-hub

Conversation

@Lms24

@Lms24Lms24 commented Feb 14, 2024

Copy link
Copy Markdown
Member

Since we deleted @sentry/hub in #10530, we also removed the craft NPM target for the hub package. Given that the craft config is always taken from develop (generally, the default branch of the repository), Craft no longer published @sentry/hub when we cut a release from our v7 branch.

Unfortunately, the NPM target does not support an optional onlyIfPresent configuration, meaning for now, we have to continue publishing a @sentry/hub placeholder package when we cut a release from develop (i.e. our v8 branch at the moment).

I'll spend some time trying to adjust our publishing/craft process to finally unblock us here. We shouldn't have to continue publishing a placeholder just to ensure we can publish v7 correctly.

@Lms24
Lms24 marked this pull request as draft February 14, 2024 16:31
Comment threaddev-packages/browser-integration-tests/utils/generatePlugin.ts Outdated
@Lms24
Lms24force-pushed the lms/fix-craft-config-hub branch from 7d438a1 to ce5163dCompareFebruary 14, 2024 16:34
@github-actions

github-actionsBot commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)77.82 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)69.06 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)72.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)62.67 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped)33.25 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)33.15 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.16 KB (0%)
@sentry/browser - Webpack (gzipped)22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)76.11 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.64 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)33.6 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped)24.71 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)212.88 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)101.5 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)74.01 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)36.83 KB (+0.04% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)69.43 KB (0%)
@sentry/react - Webpack (gzipped)22.45 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.19 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped)50.36 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped)17.12 KB (0%)

@Lms24
Lms24 marked this pull request as ready for review February 14, 2024 17:28
@Lms24
Lms24 merged commit bc79d32 into developFeb 14, 2024
@Lms24
Lms24 deleted the lms/fix-craft-config-hub branch February 14, 2024 18:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@mydea