Uh oh!
There was an error while loading. Please reload this page.
feat(node): Ensure tracing without performance (TWP) works - #11564
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 15, 2024
lforst
left a comment
Contributor
There was a problem hiding this comment.
Important tests.
To me, this change screams that we need to decouple our propagation logic from opentlemetry as it seem like OTEL is a bit incompatible with our concept for twp.
Comment on lines
+94
to
+98
| const scopes = getCapturedScopesOnSpan(span); | ||
| const isolationScope = (scopes.isolationScope || getIsolationScope()).clone(); | ||
| const scope = scopes.scope || getCurrentScope(); |
Contributor
There was a problem hiding this comment.
Why are we moving this above the early return? As far as I can see it doesn't do anything right? (Also the "Update the isolation scope, isolate this request" comment is a bit orphanded now)
MemberAuthor
There was a problem hiding this comment.
good point, I moved stuff around multiple times here, will move it back down!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lms24
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the node SDK to make tracing without performance work as expected.
This has three aspects:
tracePropagationTargets, even if the span is not sampled.The fix for 2. was to have a fallback behavior if we don't have a scope linked to a context yet (we'll just use the current scope then). This is needed because we won't necessarily have an assigned scope yet at the time this is called, because at this point in time this is still a floating context. This also meant removing the fallback code to look at the remote span context (because we'll always have a scope now).
The fix for 3. was to move this out of the http integration and do this in the sampler instead.
The fix for 1. was a bit more elaborate, because we require different things to solve the http instrumentation and the fetch instrumentation.
For fetch, we leverage our sampler, which can attach trace state that even unsampled spans will have. We attach the URL as trace state which we can read in the propagator, ensuring this works even for unsampled spans.
Sadly, for http this is not sufficient, because our usage of
onlyIfParentForOutgoingRequestlead to some spans being created outside of the sampler. By removing this option (see 3) and doing stuff in the sampler instead, we can ensure that all spans for http are handled properly.This also bumps our node-fetch otel instrumentation to 1.2.0 which fixes headers for Node 21 (tests were actually failing without this!).